have osc status highlight disabled deployment configs

Author: deads2k

pkg/cmd/cli/describe/projectstatus.go

@@ -76,11 +76,12 @@ func (d *ProjectStatusDescriber) Describe(namespace, name string) (string, error
 
 	return tabbedString(func(out *tabwriter.Writer) error {
 		indent := "  "
-		if len(project.Annotations[projectapi.ProjectDisplayName]) > 0 &&
-			project.Annotations[projectapi.ProjectDisplayName] != namespace {
-			fmt.Fprintf(out, "In project %s (%s)\n", project.Annotations[projectapi.ProjectDisplayName], namespace)
-		} else {
-			fmt.Fprintf(out, "In project %s\n", namespace)
+		fmt.Fprintf(out, "In project %s\n", projectapi.DisplayNameAndNameForProject(project))
+
+		if disabledDCs := disabledDeploymentConfigs(dcs); len(disabledDCs) > 0 {
+			fmt.Fprintln(out)
+			fmt.Fprintln(out, "Some DeploymentConfigs do not have any automatic triggers.  They can only be triggered by manually calling `osc deploy <name> --latest`.")
+			printLines(out, indent, 1, describeDisabledDeploymentConfigs(disabledDCs)...)
 		}
 
 		for _, group := range groups {
@@ -119,6 +120,25 @@ func (d *ProjectStatusDescriber) Describe(namespace, name string) (string, error
 	})
 }
 
+func disabledDeploymentConfigs(dcs *deployapi.DeploymentConfigList) []deployapi.DeploymentConfig {
+	disabledDCs := []deployapi.DeploymentConfig{}
+	for _, dc := range dcs.Items {
+		if len(dc.Triggers) == 0 {
+			disabledDCs = append(disabledDCs, dc)
+		}
+	}
+
+	return disabledDCs
+}
+func describeDisabledDeploymentConfigs(dcs []deployapi.DeploymentConfig) []string {
+	lines := []string{}
+	for _, dc := range dcs {
+		lines = append(lines, fmt.Sprintf("%s - trigger a new Deployment by running `osc deploy %s --latest`", dc.Name, dc.Name))
+	}
+
+	return lines
+}
+
 func printLines(out io.Writer, indent string, depth int, lines ...string) {
 	for i, s := range lines {
 		fmt.Fprintf(out, strings.Repeat(indent, depth))

pkg/cmd/cli/describe/projectstatus_test.go

@@ -40,7 +40,7 @@ func TestProjectStatus(t *testing.T) {
 						Name:      "example",
 						Namespace: "",
 						Annotations: map[string]string{
-							"openshift.io/display-name": "Test",
+							projectapi.ProjectDisplayName: "Test",
 						},
 					},
 				},