sa: make docker registry service controller check all secrets

Author: mfojtik

pkg/serviceaccounts/controllers/docker_registry_service.go

@@ -241,18 +241,14 @@ func getDockerRegistryLocations(lister listers.ServiceLister, location serviceLo
 func (e *DockerRegistryServiceController) syncRegistryLocationChange(key string) error {
 	newLocations := e.getDockerRegistryLocations()
 	newDockerRegistryLocations := sets.NewString(newLocations...)
-	existingURLs := e.getRegistryURLs()
-	if existingURLs.Equal(newDockerRegistryLocations) {
-		glog.V(4).Infof("No effective update: %v", newDockerRegistryLocations)
-		return nil
-	}
 
 	// make sure that new dockercfg secrets get the correct locations
 	e.dockercfgController.SetDockerURLs(newDockerRegistryLocations.List()...)
 	e.setRegistryURLs(newDockerRegistryLocations.List()...)
 
-	// we've changed the docker registry URL.  Add items to the work queue for all known secrets
-	// new secrets will already get the updated value.
+	// Add all dockercfg secrets into the work queue even if the Docker registry service location was
+	// not changed. The syncSecretUpdate will make sure the secrets have dockercfg that include all
+	// locations (DNS and ClusterIP).
 	for _, obj := range e.secretCache.List() {
 		switch t := obj.(type) {
 		case *v1.Secret: