Skip to content

Commit 5250fc0

Browse files
committed
Avoid parsing the whole dump-flows output in the OVS health check
1 parent d076bb5 commit 5250fc0

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

pkg/network/node/ovscontroller.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,10 @@ func (oc *ovsController) AlreadySetUp() bool {
5858
return false
5959
}
6060
expectedVersionNote := oc.getVersionNote()
61-
for _, flow := range flows {
62-
parsed, err := ovs.ParseFlow(ovs.ParseForDump, flow)
63-
if err == nil && parsed.Table == ruleVersionTable && parsed.NoteHasPrefix(expectedVersionNote) {
64-
return true
61+
for i := len(flows)-1; i >= 0; i-- {
62+
parsed, err := ovs.ParseFlow(ovs.ParseForDump, flows[i])
63+
if err == nil && parsed.Table == ruleVersionTable {
64+
return parsed.NoteHasPrefix(expectedVersionNote)
6565
}
6666
}
6767
return false

0 commit comments

Comments
 (0)