Skip to content

Commit 4ad399e

Browse files
committed
add Local and Unstructured builder attributes
1 parent 3f9c37d commit 4ad399e

28 files changed

+63
-39
lines changed

pkg/oc/admin/migrate/migrator.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ func (o *ResourceOptions) Complete(f *clientcmd.Factory, c *cobra.Command) error
212212
break
213213
}
214214

215-
o.Builder = f.NewBuilder(true).
215+
o.Builder = f.NewBuilder().
216216
AllNamespaces(allNamespaces).
217217
FilenameParam(false, &resource.FilenameOptions{Recursive: false, Filenames: o.Filenames}).
218218
ContinueOnError().

pkg/oc/admin/network/project_options.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ func (p *ProjectOptions) Complete(f *clientcmd.Factory, c *cobra.Command, args [
5858
return err
5959
}
6060

61-
p.Builder = f.NewBuilder(true)
61+
p.Builder = f.NewBuilder()
6262
p.DefaultNamespace = defaultNamespace
6363
p.Oclient = networkClient
6464
p.Kclient = kc

pkg/oc/admin/node/node_options.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ func (n *NodeOptions) Complete(f *clientcmd.Factory, c *cobra.Command, args []st
7575
}
7676
mapper, typer := f.Object()
7777

78-
n.Builder = f.NewBuilder(true)
78+
n.Builder = f.NewBuilder()
7979
n.DefaultNamespace = defaultNamespace
8080
n.ExternalKubeClient = externalkc
8181
n.KubeClient = kc

pkg/oc/admin/policy/review.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ func (o *sccReviewOptions) Complete(f *clientcmd.Factory, args []string, cmd *co
107107
return fmt.Errorf("unable to obtain client: %v", err)
108108
}
109109
o.client = securityClient.Security()
110-
o.builder = f.NewBuilder(true)
110+
o.builder = f.NewBuilder()
111111
o.RESTClientFactory = f.ClientForMapping
112112

113113
output := kcmdutil.GetFlagString(cmd, "output")

pkg/oc/admin/policy/subject_review.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ func (o *sccSubjectReviewOptions) Complete(f *clientcmd.Factory, args []string,
108108
}
109109
o.sccSubjectReviewClient = securityClient.Security()
110110
o.sccSelfSubjectReviewClient = securityClient.Security()
111-
o.builder = f.NewBuilder(true)
111+
o.builder = f.NewBuilder()
112112
o.RESTClientFactory = f.ClientForMapping
113113

114114
output := kcmdutil.GetFlagString(cmd, "output")

pkg/oc/bootstrap/docker/openshift/import.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ func ImportObjects(f *clientcmd.Factory, ns, location string) error {
2424
return err
2525
}
2626
glog.V(8).Infof("Importing data:\n%s\n", string(data))
27-
r := f.NewBuilder(true).
27+
r := f.NewBuilder().
2828
Schema(schema).
2929
ContinueOnError().
3030
NamespaceParam(ns).

pkg/oc/cli/cmd/debug.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ func (o *DebugOptions) Complete(cmd *cobra.Command, f *clientcmd.Factory, args [
221221
}
222222

223223
mapper, _ := f.Object()
224-
b := f.NewBuilder(true).
224+
b := f.NewBuilder().
225225
NamespaceParam(cmdNamespace).DefaultNamespace().
226226
SingleResourceType().
227227
ResourceNames("pods", resources...).

pkg/oc/cli/cmd/deploy.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ func (o *DeployOptions) Complete(f *clientcmd.Factory, args []string, out io.Wri
155155
return err
156156
}
157157

158-
o.builder = f.NewBuilder(true)
158+
o.builder = f.NewBuilder()
159159
o.out = out
160160

161161
if len(args) > 0 {

pkg/oc/cli/cmd/export.go

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -110,17 +110,13 @@ func RunExport(f *clientcmd.Factory, exporter Exporter, in io.Reader, out io.Wri
110110
return err
111111
}
112112

113-
builder, err := f.NewUnstructuredBuilder(true)
114-
if err != nil {
115-
return err
116-
}
117-
118113
mapper, typer, err := f.UnstructuredObject()
119114
if err != nil {
120115
return err
121116
}
122117

123-
b := builder.
118+
b := f.NewBuilder().
119+
Unstructured(f.UnstructuredClientForMapping, mapper, typer).
124120
NamespaceParam(cmdNamespace).DefaultNamespace().AllNamespaces(allNamespaces).
125121
FilenameParam(explicit, &resource.FilenameOptions{Recursive: false, Filenames: filenames}).
126122
SelectorParam(selector).

pkg/oc/cli/cmd/expose.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ func validate(cmd *cobra.Command, f *clientcmd.Factory, args []string) error {
9393
return err
9494
}
9595

96-
r := f.NewBuilder(true).
96+
r := f.NewBuilder().
9797
ContinueOnError().
9898
NamespaceParam(namespace).DefaultNamespace().
9999
FilenameParam(enforceNamespace, &resource.FilenameOptions{Recursive: false, Filenames: kcmdutil.GetFlagStringSlice(cmd, "filename")}).

0 commit comments

Comments
 (0)