Merge pull request #17983 from mfojtik/oc-status-dc

Automatic merge from submit-queue.

cli: fix nil pointer panic in dc status

Fixes: #17977

This change is weird as you should not be able to create a DC without template, but I haven't looked deeply on how the graph is constructed and whether this case can happen. We protect from nil template in other function.

Author: openshift-merge-robot

pkg/apps/graph/edges.go

@@ -1,6 +1,7 @@
 package graph
 
 import (
+	"github.com/golang/glog"
 	"github.com/gonum/graph"
 
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -92,7 +93,12 @@ func AddAllDeploymentEdges(g osgraph.MutableUniqueGraph) {
 }
 
 func AddVolumeClaimEdges(g osgraph.Graph, dcNode *appsgraph.DeploymentConfigNode) {
-	for _, volume := range dcNode.DeploymentConfig.Spec.Template.Spec.Volumes {
+	podTemplate := dcNode.DeploymentConfig.Spec.Template
+	if podTemplate == nil {
+		glog.Warningf("DeploymentConfig %s/%s template should not be empty", dcNode.DeploymentConfig.Namespace, dcNode.DeploymentConfig.Name)
+		return
+	}
+	for _, volume := range podTemplate.Spec.Volumes {
 		source := volume.VolumeSource
 		if source.PersistentVolumeClaim == nil {
 			continue
@@ -113,7 +119,7 @@ func AddVolumeClaimEdges(g osgraph.Graph, dcNode *appsgraph.DeploymentConfigNode
 
 func AddAllVolumeClaimEdges(g osgraph.Graph) {
 	for _, node := range g.Nodes() {
-		if dcNode, ok := node.(*appsgraph.DeploymentConfigNode); ok {
+		if dcNode, ok := node.(*appsgraph.DeploymentConfigNode); ok && dcNode.IsFound {
 			AddVolumeClaimEdges(g, dcNode)
 		}
 	}