Merge pull request #2121 from csrwng/bug_1214229

Merged by openshift-bot

Author: OpenShift Bot

pkg/authorization/api/types.go

@@ -51,7 +51,7 @@ const (
 
 var (
 	GroupsToResources = map[string][]string{
-		BuildGroupName:              {"builds", "buildconfigs", "buildlogs", "buildconfigs/instantiate", "builds/log"},
+		BuildGroupName:              {"builds", "buildconfigs", "buildlogs", "buildconfigs/instantiate", "builds/log", "builds/clone"},
 		ImageGroupName:              {"images", "imagerepositories", "imagerepositorymappings", "imagerepositorytags", "imagestreams", "imagestreammappings", "imagestreamtags", "imagestreamimages"},
 		DeploymentGroupName:         {"deployments", "deploymentconfigs", "generatedeploymentconfigs", "deploymentconfigrollbacks"},
 		UserGroupName:               {"identities", "users", "useridentitymappings"},

pkg/authorization/rulevalidation/policy_comparator_test.go

@@ -82,7 +82,7 @@ func TestResourceGroupCoveringEnumerated(t *testing.T) {
 func TestEnumeratedCoveringResourceGroup(t *testing.T) {
 	escalationTest{
 		ownerRules: []authorizationapi.PolicyRule{
-			{Verbs: util.NewStringSet("delete", "update"), Resources: util.NewStringSet("builds", "buildconfigs", "buildlogs", "buildconfigs/instantiate", "builds/log")},
+			{Verbs: util.NewStringSet("delete", "update"), Resources: util.NewStringSet("builds", "buildconfigs", "buildlogs", "buildconfigs/instantiate", "builds/log", "builds/clone")},
 		},
 		servantRules: []authorizationapi.PolicyRule{
 			{Verbs: util.NewStringSet("delete", "update"), Resources: util.NewStringSet("resourcegroup:builds")},
@@ -110,6 +110,8 @@ func TestEnumeratedMissingPartOfResourceGroup(t *testing.T) {
 			{Verbs: util.NewStringSet("update"), Resources: util.NewStringSet("buildconfigs/instantiate")},
 			{Verbs: util.NewStringSet("delete"), Resources: util.NewStringSet("builds/log")},
 			{Verbs: util.NewStringSet("update"), Resources: util.NewStringSet("builds/log")},
+			{Verbs: util.NewStringSet("delete"), Resources: util.NewStringSet("builds/clone")},
+			{Verbs: util.NewStringSet("update"), Resources: util.NewStringSet("builds/clone")},
 		},
 	}.test(t)
 }