Skip to content

Conversation

wolfy1339
Copy link
Member

See octokit/octokit.js#2762 (comment)

Resolves #ISSUE_NUMBER


Before the change?

  • Types would include a reference to @types/node even though there is nothing using Node specific APIs in the types

After the change?

  • Update @octokit/types to make sure types are platform agnostic

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@wolfy1339 wolfy1339 added the Type: Bug Something isn't working as documented label Jan 3, 2025
@wolfy1339 wolfy1339 requested a review from oscard0m January 7, 2025 15:54
@oscard0m oscard0m merged commit 553f0b4 into main Jan 7, 2025
8 checks passed
@oscard0m oscard0m deleted the bump-octokit branch January 7, 2025 17:53
Copy link
Contributor

github-actions bot commented Jan 7, 2025

🎉 This PR is included in version 9.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Bug Something isn't working as documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants