-
Notifications
You must be signed in to change notification settings - Fork 446
Closed
Description
Expected Behavior
When rpc connection is terminated unexpectedly, status code should be non zero.
Actual Behavior
When rpc connection is terminated unexpectedly, status code is zero.
Reproduction
- Open a terminal with a dune build in watch mode
- On another terminal, call
dune build <some_target>; echo "dune exit code: $?"
- Kill the dune process in first terminal
Second terminal will show:
Error: { payload = Some [ [ "id"; [ "auto"; "0" ] ] ]
; message =
"connection terminated. this request will never receive a response"
; kind = Connection_dead
}
dune exit code: 0
Specifications
- Version of
dune
(output ofdune --version
):3.19.1
- Version of
ocaml
(output ofocamlc --version
):4.14.0