From 3c7d5864f2a9946b92c0a3833a7a402a809c759f Mon Sep 17 00:00:00 2001 From: jakecastelli Date: Tue, 24 Sep 2024 21:15:58 +0930 Subject: [PATCH 1/3] test: deflake test/pummel/test-timers.js --- test/pummel/test-timers.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/pummel/test-timers.js b/test/pummel/test-timers.js index 2f5580840231e3..7c372a7ab2b01e 100644 --- a/test/pummel/test-timers.js +++ b/test/pummel/test-timers.js @@ -36,7 +36,7 @@ const WINDOW = 200; // Why does this need to be so big? assert.ok(diff > 0); console.error(`diff: ${diff}`); - assert.ok(1000 <= diff && diff < 1000 + WINDOW); + assert.ok(Math.abs(diff - 1000) < WINDOW && diff < 1000 + WINDOW); }), 1000); } @@ -61,7 +61,7 @@ const WINDOW = 200; // Why does this need to be so big? const t = interval_count * 1000; - assert.ok(t <= diff && diff < t + (WINDOW * interval_count)); + assert.ok(Math.abs(diff - t) < WINDOW && diff < t + (WINDOW * interval_count)); assert.ok(interval_count <= 3, `interval_count: ${interval_count}`); if (interval_count === 3) From aef35bcb906f37af54b4bb651b29fc5ec83dc872 Mon Sep 17 00:00:00 2001 From: jakecastelli Date: Tue, 24 Sep 2024 21:54:40 +0930 Subject: [PATCH 2/3] fixup! remove unnecessary check --- test/pummel/test-timers.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/pummel/test-timers.js b/test/pummel/test-timers.js index 7c372a7ab2b01e..3ed922af7aedec 100644 --- a/test/pummel/test-timers.js +++ b/test/pummel/test-timers.js @@ -36,7 +36,7 @@ const WINDOW = 200; // Why does this need to be so big? assert.ok(diff > 0); console.error(`diff: ${diff}`); - assert.ok(Math.abs(diff - 1000) < WINDOW && diff < 1000 + WINDOW); + assert.ok(Math.abs(diff - 1000) < WINDOW); }), 1000); } From d9c53b053e2b42dd6978d40d2152ba10574acbd0 Mon Sep 17 00:00:00 2001 From: jakecastelli Date: Wed, 25 Sep 2024 11:20:02 +0930 Subject: [PATCH 3/3] fixup! remove more checks --- test/pummel/test-timers.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/pummel/test-timers.js b/test/pummel/test-timers.js index 3ed922af7aedec..74d9f4eb41e684 100644 --- a/test/pummel/test-timers.js +++ b/test/pummel/test-timers.js @@ -61,7 +61,7 @@ const WINDOW = 200; // Why does this need to be so big? const t = interval_count * 1000; - assert.ok(Math.abs(diff - t) < WINDOW && diff < t + (WINDOW * interval_count)); + assert.ok(Math.abs(diff - t) < WINDOW * interval_count); assert.ok(interval_count <= 3, `interval_count: ${interval_count}`); if (interval_count === 3)