Skip to content

Commit a38d71d

Browse files
committed
build: remove deprecated calls for argument groups
I'm not sure what the purpose of these `add_argument_group()` calls are that pass in an existing argument group but they are deprecated and may be removed, see the [Python documentation for notice](https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.add_argument_group). > [!WARNING] > *Changed in version 3.11*: Calling `add_argument_group()` on an > argument group is deprecated. This feature was never supported and > does not always work correctly. The function exists on the API by > accident through inheritance and will be removed in the future.
1 parent 2863c54 commit a38d71d

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

configure.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -448,8 +448,6 @@
448448
dest='shared_cares_libpath',
449449
help='a directory to search for the shared cares DLL')
450450

451-
parser.add_argument_group(shared_optgroup)
452-
453451
for builtin in shareable_builtins:
454452
builtin_id = 'shared_builtin_' + builtin + '_path'
455453
shared_builtin_optgroup.add_argument('--shared-builtin-' + builtin + '-path',
@@ -458,15 +456,11 @@
458456
help='Path to shared file for ' + builtin + ' builtin. '
459457
'Will be used instead of bundled version at runtime')
460458

461-
parser.add_argument_group(shared_builtin_optgroup)
462-
463459
static_optgroup.add_argument('--static-zoslib-gyp',
464460
action='store',
465461
dest='static_zoslib_gyp',
466462
help='path to zoslib.gyp file for includes and to link to static zoslib library')
467463

468-
parser.add_argument_group(static_optgroup)
469-
470464
parser.add_argument('--tag',
471465
action='store',
472466
dest='tag',
@@ -646,8 +640,6 @@
646640
default='deps',
647641
help='Download directory [default: %(default)s]')
648642

649-
parser.add_argument_group(intl_optgroup)
650-
651643
parser.add_argument('--debug-lib',
652644
action='store_true',
653645
dest='node_debug_lib',
@@ -660,8 +652,6 @@
660652
default=None,
661653
help='build nghttp2 with DEBUGBUILD (default is false)')
662654

663-
parser.add_argument_group(http2_optgroup)
664-
665655
parser.add_argument('--without-npm',
666656
action='store_true',
667657
dest='without_npm',

0 commit comments

Comments
 (0)