adding tests for runtime manager

Author: miledxz

internal/mode/static/nginx/runtime/manager.go

@@ -19,8 +19,11 @@ import (
 //go:generate go run github.com/maxbrunsfeld/counterfeiter/v6 -generate
 
 const (
-	PidFile            = "/var/run/nginx/nginx.pid"
-	pidFileTimeout     = 10000 * time.Millisecond
+	// PidFile specifies the location of the PID file for the Nginx process
+	PidFile = "/var/run/nginx/nginx.pid"
+	// pidFileTimeout defines the timeout duration for accessing the PID file
+	pidFileTimeout = 10000 * time.Millisecond
+	/// NginxReloadTimeout sets the timeout duration for reloading the Nginx configuration
 	NginxReloadTimeout = 60000 * time.Millisecond
 )
 
@@ -60,8 +63,6 @@ type ProcessHandler interface {
 	EnsureNginxRunning(ctx context.Context) error
 }
 
-type ProcessHandlerImpl struct{}
-
 //go:generate go run github.com/maxbrunsfeld/counterfeiter/v6 . Manager
 
 // Manager manages the runtime of NGINX.
@@ -91,7 +92,7 @@ type MetricsCollector interface {
 type ManagerImpl struct {
 	processHandler   ProcessHandler
 	metricsCollector MetricsCollector
-	verifyClient     verifyClient
+	verifyClient     nginxConfigVerifier
 	ngxPlusClient    nginxPlusClient
 	logger           logr.Logger
 }
@@ -102,7 +103,7 @@ func NewManagerImpl(
 	collector MetricsCollector,
 	logger logr.Logger,
 	processHandler ProcessHandler,
-	verifyClient verifyClient,
+	verifyClient nginxConfigVerifier,
 ) *ManagerImpl {
 	return &ManagerImpl{
 		processHandler:   processHandler,
@@ -190,6 +191,8 @@ func (m *ManagerImpl) GetUpstreams() (ngxclient.Upstreams, error) {
 	return *upstreams, nil
 }
 
+type ProcessHandlerImpl struct{}
+
 // EnsureNginxRunning ensures NGINX is running by locating the main process.
 func (p *ProcessHandlerImpl) EnsureNginxRunning(ctx context.Context) error {
 	if _, err := p.FindMainProcess(ctx, os.Stat, os.ReadFile, pidFileTimeout); err != nil {

internal/mode/static/nginx/runtime/manager_test.go

@@ -51,15 +51,18 @@ var _ = Describe("NGINX Runtime Manager", func() {
 			manager = runtime.NewManagerImpl(ngxPlusClient, metrics, zap.New(), process, verifyClient)
 		})
 
-		It("NGINX configuration reload is successful", func() {
-			Expect(manager.Reload(context.Background(), 1)).To(Succeed())
-
-			Expect(process.FindMainProcessCallCount()).To(Equal(1))
-			Expect(process.ReadFileCallCount()).To(Equal(1))
-			Expect(process.KillCallCount()).To(Equal(1))
-			Expect(metrics.IncReloadCountCallCount()).To(Equal(1))
-			Expect(verifyClient.WaitForCorrectVersionCallCount()).To(Equal(1))
-			Expect(metrics.ObserveLastReloadTimeCallCount()).To(Equal(1))
+		When("MetricsCollector is nil", func() {
+			It("NGINX configuration reload is successful", func() {
+				Expect(manager.Reload(context.Background(), 1)).To(Succeed())
+
+				Expect(process.FindMainProcessCallCount()).To(Equal(1))
+				Expect(process.ReadFileCallCount()).To(Equal(1))
+				Expect(process.KillCallCount()).To(Equal(1))
+				Expect(metrics.IncReloadCountCallCount()).To(Equal(1))
+				Expect(verifyClient.WaitForCorrectVersionCallCount()).To(Equal(1))
+				Expect(metrics.ObserveLastReloadTimeCallCount()).To(Equal(1))
+				Expect(metrics.IncReloadErrorsCallCount()).To(Equal(0))
+			})
 		})
 
 		When("NGINX configuration reload is not successful", func() {
@@ -100,12 +103,22 @@ var _ = Describe("NGINX Runtime Manager", func() {
 			Expect(manager.UpdateHTTPServers("test", upstreamServers)).To(Succeed())
 		})
 
-		It("returns no upstreams from NGINX Plus API", func() {
+		It("returns no upstreams from NGINX Plus API when upstreams are nil", func() {
 			upstreams, err := manager.GetUpstreams()
 
 			Expect(err).To(HaveOccurred())
 			Expect(upstreams).To(BeEmpty())
 		})
+
+		It("returns an error when GetUpstreams fails", func() {
+			ngxPlusClient.GetUpstreamsReturns(nil, errors.New("failed to get upstreams"))
+
+			upstreams, err := manager.GetUpstreams()
+
+			Expect(err).To(HaveOccurred())
+			Expect(err).To(MatchError("failed to get upstreams"))
+			Expect(upstreams).To(BeNil())
+		})
 	})
 
 	When("not running NGINX plus", func() {

internal/mode/static/nginx/runtime/verify.go

@@ -21,7 +21,7 @@ var noNewWorkersErrFmt = "reload unsuccessful: no new NGINX worker processes sta
 
 //go:generate go run github.com/maxbrunsfeld/counterfeiter/v6 . verifyClient
 
-type verifyClient interface {
+type nginxConfigVerifier interface {
 	GetConfigVersion() (int, error)
 	WaitForCorrectVersion(
 		ctx context.Context,