Skip to content
This repository was archived by the owner on Apr 19, 2024. It is now read-only.

Commit cdbc95c

Browse files
committed
.github/workflows: update NodeJS to 20
With all dependency upgrade I've done, the support for NodeJS 12 is now broken. So it's time to move on to a newer, still supported version. NodeJS 20 is choosen because a.) while it's not an LTS yet, it will become an LTS soon, and b.) it matches the version in netdev/devenv Docker image.
1 parent ea03c76 commit cdbc95c

File tree

2 files changed

+13
-9
lines changed

2 files changed

+13
-9
lines changed

.github/workflows/npm-test.yml

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,11 @@ jobs:
1414
- name: Prepare Node.js
1515
uses: actions/setup-node@v1
1616
with:
17-
node-version: '12.x'
18-
- name: Run `npm install`
19-
run: npm install
17+
node-version: '20.x'
18+
- name: Run `npm ci`
19+
# See the PR below for why `--legacy-peer-deps`` is needed.
20+
# https://github.com/netdata/dashboard/pull/467
21+
run: npm ci --legacy-peer-deps
2022
- name: Run `npm test`
2123
run: npm test
2224
npm-lint:
@@ -28,8 +30,8 @@ jobs:
2830
- name: Prepare Node.js
2931
uses: actions/setup-node@v1
3032
with:
31-
node-version: '12.x'
32-
- name: Run `npm install`
33-
run: npm install
33+
node-version: '20.x'
34+
- name: Run `npm ci`
35+
run: npm ci --legacy-peer-deps
3436
- name: Run `npm run lint`
3537
run: npm run lint

.github/workflows/release.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,11 @@ jobs:
1717
- name: 'Prepare Node.js'
1818
uses: actions/setup-node@v1
1919
with:
20-
node-version: '12.x'
21-
- name: 'Fetch Dependencies'
22-
run: npm install
20+
node-version: '20.x'
21+
- name: Run `npm ci`
22+
# See the PR below for why `--legacy-peer-deps`` is needed.
23+
# https://github.com/netdata/dashboard/pull/467
24+
run: npm ci --legacy-peer-deps
2325
- name: 'Build Dashboard'
2426
run: npm run build
2527
- name: 'Prepare Tarball'

0 commit comments

Comments
 (0)