Merge branch 'linting'

Author: mxmul

.eslintrc

@@ -0,0 +1,7 @@
+{
+    "extends": "@sharkcore",
+    "plugins": ["jest"],
+    "env": {
+        "jest/globals": true,
+    }
+}

lib/dependency-map-builder.js

@@ -1,30 +1,14 @@
-var _ = require('lodash'),
-    path = require('path'),
-    chokidar = require('chokidar'),
-    Promise = require('bluebird'),
-    cache = {},
-    glob = Promise.promisify(require('glob')),
-    fs = require('graceful-fs'),
-    lstat = Promise.promisify(fs.lstat),
-    readFile = Promise.promisify(fs.readFile),
-    provideRegExp = /goog\.provide\((['"])(([^.)]+)[^)]*)\1\)/g;
+const _ = require('lodash');
+const path = require('path');
+const chokidar = require('chokidar');
+const Promise = require('bluebird');
+const glob = Promise.promisify(require('glob'));
+const fs = require('graceful-fs');
 
-/**
- * Fulfills in an object wich maps namespaces to file paths found in given
- * directories.
- *
- * @param {string[]} directories Directories to be processed
- * @param {boolean} watch Watch for changes is mapped files to invalidate cache
- * @param {string} fileExt Searched file extensions
- * @returns {Promise}
- */
-module.exports = function (directories, watch, fileExt) {
-    return Promise.map(directories, function(dir) {
-        return resolveAndCacheDirectory(dir, watch, fileExt)
-    }).then(function(results) {
-        return _.assign.apply(_, results);
-    })
-};
+const cache = {};
+const lstat = Promise.promisify(fs.lstat);
+const readFile = Promise.promisify(fs.readFile);
+const provideRegExp = /goog\.provide\((['"])(([^.)]+)[^)]*)\1\)/g;
 
 /**
  * Promisified watch
@@ -35,14 +19,39 @@ module.exports = function (directories, watch, fileExt) {
  * @returns {Promise}
  */
 function createWatchPromise(directory) {
-    return new Promise(function(resolve, reject) {
-        var watcher = chokidar.watch(directory)
-            .on('ready', function() {
-                watcher.on('all', function() {
-                    delete cache[directory];
-                });
-                resolve(watcher);
+    return new Promise(resolve => {
+        const watcher = chokidar.watch(directory).on('ready', () => {
+            watcher.on('all', () => {
+                delete cache[directory];
             });
+            resolve(watcher);
+        });
+    });
+}
+
+/**
+ * Scans the given file path for occurences of `goog.provide()` and fulfills
+ * in an object wich mapps each namespace to the file path
+ *
+ * @param {string} filePath
+ * @returns {Promise}
+ */
+function findProvideCalls(filePath) {
+    return lstat(filePath).then(stats => {
+        if (!stats.isFile()) {
+            return {};
+        }
+
+        return readFile(filePath).then(fileContent => {
+            const result = {};
+
+            let matches = null;
+            // eslint-disable-next-line no-cond-assign
+            while ((matches = provideRegExp.exec(fileContent)) !== null) {
+                result[matches[2]] = filePath;
+            }
+            return result;
+        });
     });
 }
 
@@ -57,44 +66,32 @@ function createWatchPromise(directory) {
  * @returns {Promise}
  */
 function resolveAndCacheDirectory(directory, watch, fileExt) {
-
     if (cache[directory]) {
         return cache[directory];
     }
 
-    cache[directory] = (watch ? createWatchPromise(directory) : Promise.resolve())
-        .then(function() {
-            return glob(path.join(directory, '**', '*' + fileExt));
-        })
-        .map(function(filePath) {
-            return findProvideCalls(filePath);
-        })
-        .then(function(results) {
-            return _.assign.apply(_, results);
-        });
+    cache[directory] = (watch
+        ? createWatchPromise(directory)
+        : Promise.resolve()
+    )
+        .then(() => glob(path.join(directory, '**', `*${fileExt}`)))
+        .map(filePath => findProvideCalls(filePath))
+        .then(results => _.assign(...results));
 
     return cache[directory];
 }
 
 /**
- * Scans the given file path for occurences of `goog.provide()` and fulfills
- * in an object wich mapps each namespace to the file path
+ * Fulfills in an object wich maps namespaces to file paths found in given
+ * directories.
  *
- * @param {string} filePath
+ * @param {string[]} directories Directories to be processed
+ * @param {boolean} watch Watch for changes is mapped files to invalidate cache
+ * @param {string} fileExt Searched file extensions
  * @returns {Promise}
  */
-function findProvideCalls(filePath) {
-    return lstat(filePath).then(function (stats) {
-        if (!stats.isFile()) {
-            return {};
-        }
-
-        return readFile(filePath).then(function(fileContent) {
-            var result = {};
-            while (matches = provideRegExp.exec(fileContent)) {
-                result[matches[2]] = filePath;
-            }
-            return result;
-        });
-    });
-}
+module.exports = function dependencyMapBuilder(directories, watch, fileExt) {
+    return Promise.map(directories, dir =>
+        resolveAndCacheDirectory(dir, watch, fileExt),
+    ).then(results => _.assign(...results));
+};

lib/export-path.js

@@ -1,24 +1,25 @@
 /**
-* Ensure that a dotted path is defined on a namespace object. Will create
-* intermediate namespaces that are not defined as empty objects, and will
-* optionally set a value at the end of the path.
-*
+ * Ensure that a dotted path is defined on a namespace object. Will create
+ * intermediate namespaces that are not defined as empty objects, and will
+ * optionally set a value at the end of the path.
+ *
  * @param {Object} namespace
  * @param {string} name
  * @param {*=} value
-*/
-module.exports = function(namespace, name, value) {
-  var parts = name.split('.');
-  var target = namespace;
+ */
+module.exports = function exportPath(namespace, name, value) {
+    const parts = name.split('.');
+    let target = namespace;
 
-  for (var i = 0; i < parts.length; i++) {
-    var part = parts[i];
-    if (i === parts.length - 1 && value !== undefined) {
-      target[part] = value;
-    } else if (target[part]) {
-      target = target[part];
-    } else {
-      target = target[part] = {};
+    for (let i = 0; i < parts.length; i += 1) {
+        const part = parts[i];
+        if (i === parts.length - 1 && value !== undefined) {
+            target[part] = value;
+        } else if (target[part]) {
+            target = target[part];
+        } else {
+            target[part] = {};
+            target = target[part];
+        }
     }
-  }
 };