[Slider][material] Fix type dependency on @types/prop-types (#37853)

Author: Methuselah96

.circleci/config.yml

@@ -269,15 +269,6 @@ jobs:
             yarn workspace @mui/material typescript:module-augmentation
             yarn workspace @mui/base typescript:module-augmentation
             yarn workspace @mui/joy typescript:module-augmentation
-
-      - restore_cache:
-          name: Restore generated declaration files
-          keys:
-            # #default-branch-switch
-            # We assume that the target branch is `master` and that declaration files are persisted in commit order.
-            # "If there are multiple matches, the most recently generated cache will be used."
-            - typescript-declaration-files-master
-
       - run:
           name: Diff declaration files
           command: |
@@ -286,7 +277,6 @@ jobs:
             git add -f packages/mui-utils/build || echo '/utils declarations do not exist'
             yarn lerna run build:types
             git --no-pager diff
-
       - run:
           name: Any defect declaration files?
           command: node scripts/testBuiltTypes.mjs

packages/mui-material-next/src/Button/Ripple.tsx

@@ -85,6 +85,6 @@ Ripple.propTypes = {
    * exit delay
    */
   timeout: PropTypes.number.isRequired,
-};
+} as any;
 
-export default Ripple;
+export default Ripple as (props: RippleProps) => JSX.Element;

packages/mui-material-next/src/Button/TouchRipple.tsx

@@ -293,6 +293,6 @@ TouchRipple.propTypes = {
    * @ignore
    */
   className: PropTypes.string,
-};
+} as any;
 
 export default TouchRipple;

packages/mui-material-next/src/Slider/Slider.tsx

@@ -105,7 +105,7 @@ SliderRoot.propTypes /* remove-proptypes */ = {
    * @ignore
    */
   children: PropTypes.node,
-};
+} as any;
 
 export { SliderRoot };
 
@@ -145,7 +145,7 @@ SliderRail.propTypes /* remove-proptypes */ = {
    * @ignore
    */
   children: PropTypes.node,
-};
+} as any;
 
 export { SliderRail };
 
@@ -193,7 +193,7 @@ SliderTrack.propTypes /* remove-proptypes */ = {
    * @ignore
    */
   children: PropTypes.node,
-};
+} as any;
 
 export { SliderTrack };
 
@@ -294,7 +294,7 @@ SliderThumb.propTypes /* remove-proptypes */ = {
    * @ignore
    */
   children: PropTypes.node,
-};
+} as any;
 
 export { SliderThumb };
 
@@ -391,7 +391,7 @@ SliderValueLabel.propTypes /* remove-proptypes */ = {
    * @ignore
    */
   children: PropTypes.element,
-};
+} as any;
 
 export { SliderValueLabel };
 
@@ -438,7 +438,7 @@ SliderMark.propTypes /* remove-proptypes */ = {
    * @ignore
    */
   children: PropTypes.node,
-};
+} as any;
 
 export { SliderMark };
 
@@ -490,7 +490,7 @@ SliderMarkLabel.propTypes /* remove-proptypes */ = {
    * @ignore
    */
   children: PropTypes.node,
-};
+} as any;
 
 export { SliderMarkLabel };
 

packages/mui-material/src/Slider/SliderValueLabel.tsx

@@ -50,4 +50,4 @@ SliderValueLabel.propTypes = {
   children: PropTypes.element.isRequired,
   className: PropTypes.string,
   value: PropTypes.node,
-};
+} as any;

scripts/buildTypes.mjs

@@ -54,6 +54,22 @@ async function main() {
 
   async function rewriteImportPaths(declarationFile) {
     const code = await fse.readFile(declarationFile, { encoding: 'utf8' });
+    const basename = path.basename(declarationFile);
+
+    if (
+      // Only consider React components
+      basename[0] === basename[0].toUpperCase() &&
+      code.indexOf("import PropTypes from 'prop-types';") !== -1
+    ) {
+      throw new Error(
+        [
+          `${declarationFile} imports from 'prop-types', this is wrong.`,
+          "It's likely missing a cast to any on the propTypes declaration:",
+          'ComponentName.propTypes = { /* prop */ } as any;',
+        ].join('\n'),
+      );
+    }
+
     let fixedCode = code;
     const changes = [];