Skip to content

Conversation

redboltz
Copy link
Contributor

Improved alignment calculation logic.

Improved alignment calculation logic.
Fixed test for zone.
Now, align parameter must be 2^n (n >=0). e.g. 1,2,4,8,16, ...
@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2021

Codecov Report

Merging #965 (ca9f25b) into cpp_master (76f5af0) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@              Coverage Diff               @@
##           cpp_master     #965      +/-   ##
==============================================
- Coverage       85.61%   85.60%   -0.02%     
==============================================
  Files              79       79              
  Lines            5005     5007       +2     
==============================================
+ Hits             4285     4286       +1     
- Misses            720      721       +1     

@redboltz
Copy link
Contributor Author

@kovdan01 Before I release the next version, I'm porting #962 (for C) to C++.

Most of work is done. But I found weird error on the CI.
Only Linux (pattern0) reports compile error
https://github.com/msgpack/msgpack-c/pull/965/checks?check_run_id=3453292555#step:8:156

Defining uintptr_t depends on implementation. It's OK.
https://en.cppreference.com/w/cpp/types/integer

But what is the difference between pattern0 and other patterns ?

Could you help me if you have time?

@kovdan01
Copy link

Could you help me if you have time?

Sure, I'll investigate the problem and write about results.

@redboltz
Copy link
Contributor Author

Thank you!

@redboltz
Copy link
Contributor Author

The compile error is caused by lack of include "cstdint". It has been introduced since C++11. For C++03 (Linux pattern 0 !), "stdint.h" can be used.

Added cstdint header for uintptr_t (for C++11 or later)
Added stdint.h header for uintptr_t (for C++03)
@redboltz redboltz merged commit c1b3d75 into msgpack:cpp_master Aug 29, 2021
@redboltz redboltz deleted the port_962_to_cpp branch August 29, 2021 13:12
@redboltz redboltz added the C++ label Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants