Skip to content

Commit 35638ea

Browse files
committed
fix style
1 parent 6507243 commit 35638ea

File tree

2 files changed

+51
-37
lines changed

2 files changed

+51
-37
lines changed

include/msgpack/v1/adaptor/cpp17/variant.hpp

Lines changed: 35 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,13 @@ template <
3232
typename T,
3333
typename... Ts,
3434
std::size_t current_index,
35-
std::size_t... indices>
35+
std::size_t... indices
36+
>
3637
Variant construct_variant(
3738
std::size_t index,
3839
msgpack::object& object,
39-
std::index_sequence<current_index, indices...>) {
40+
std::index_sequence<current_index, indices...>
41+
) {
4042
if constexpr(sizeof...(Ts) == 0) {
4143
return object.as<T>();
4244
}
@@ -45,9 +47,10 @@ Variant construct_variant(
4547
return object.as<T>();
4648
}
4749
return construct_variant<Variant, Ts...>(
48-
index,
49-
object,
50-
std::index_sequence<indices...>());
50+
index,
51+
object,
52+
std::index_sequence<indices...>()
53+
);
5154
}
5255
}
5356

@@ -70,16 +73,16 @@ template <typename... Ts>
7073
struct as<std::variant<Ts...>, typename std::enable_if<(msgpack::has_as<Ts>::value && ...)>::type> {
7174
std::variant<Ts...> operator()(msgpack::object const& o) const {
7275
if ( o.type != msgpack::type::ARRAY
73-
|| o.via.array.size != 2
74-
|| o.via.array.ptr[0].type != msgpack::type::POSITIVE_INTEGER
75-
|| o.via.array.ptr[0].via.u64 >= sizeof...(Ts)) {
76+
|| o.via.array.size != 2
77+
|| o.via.array.ptr[0].type != msgpack::type::POSITIVE_INTEGER
78+
|| o.via.array.ptr[0].via.u64 >= sizeof...(Ts)) {
7679
throw msgpack::type_error{};
7780
}
7881

7982
return detail::construct_variant<std::variant<Ts...>, Ts...>(
80-
o.via.array.ptr[0].as<std::size_t>(),
81-
o.via.array.ptr[1],
82-
std::make_index_sequence<sizeof...(Ts)>()
83+
o.via.array.ptr[0].as<std::size_t>(),
84+
o.via.array.ptr[1],
85+
std::make_index_sequence<sizeof...(Ts)>()
8386
);
8487
}
8588
};
@@ -88,16 +91,16 @@ template<typename... Ts>
8891
struct convert<std::variant<Ts...>> {
8992
msgpack::object const& operator()(msgpack::object const& o, std::variant<Ts...>& v) const {
9093
if ( o.type != msgpack::type::ARRAY
91-
|| o.via.array.size != 2
92-
|| o.via.array.ptr[0].type != msgpack::type::POSITIVE_INTEGER
93-
|| o.via.array.ptr[0].via.u64 >= sizeof...(Ts)) {
94+
|| o.via.array.size != 2
95+
|| o.via.array.ptr[0].type != msgpack::type::POSITIVE_INTEGER
96+
|| o.via.array.ptr[0].via.u64 >= sizeof...(Ts)) {
9497
throw msgpack::type_error{};
9598
}
9699

97100
v = detail::construct_variant<std::variant<Ts...>, Ts...>(
98-
o.via.array.ptr[0].as<std::size_t>(),
99-
o.via.array.ptr[1],
100-
std::make_index_sequence<sizeof...(Ts)>()
101+
o.via.array.ptr[0].as<std::size_t>(),
102+
o.via.array.ptr[1],
103+
std::make_index_sequence<sizeof...(Ts)>()
101104
);
102105
return o;
103106
}
@@ -106,7 +109,10 @@ struct convert<std::variant<Ts...>> {
106109
template <typename... Ts>
107110
struct pack<std::variant<Ts...>>{
108111
template<typename Stream>
109-
msgpack::packer<Stream>& operator()(msgpack::packer<Stream>& o, std::variant<Ts...> const& v) const {
112+
msgpack::packer<Stream>& operator()(
113+
msgpack::packer<Stream>& o,
114+
std::variant<Ts...> const& v
115+
) const {
110116
o.pack_array(2);
111117
o.pack_uint64(v.index());
112118
std::visit([&o](auto const& value){o.pack(value);}, v);
@@ -117,10 +123,17 @@ struct pack<std::variant<Ts...>>{
117123

118124
template<typename... Ts>
119125
struct object_with_zone<std::variant<Ts...>> {
120-
void operator()(msgpack::object::with_zone& o, std::variant<Ts...> const& v) const {
121-
msgpack::object *p = static_cast<msgpack::object *>(
122-
o.zone.allocate_align(sizeof(msgpack::object) * 2,
123-
MSGPACK_ZONE_ALIGNOF(msgpack::object)));
126+
void operator()(
127+
msgpack::object::with_zone& o,
128+
std::variant<Ts...> const& v
129+
) const {
130+
msgpack::object *p =
131+
static_cast<msgpack::object *>(
132+
o.zone.allocate_align(
133+
sizeof(msgpack::object) * 2,
134+
MSGPACK_ZONE_ALIGNOF(msgpack::object)
135+
)
136+
);
124137

125138
o.type = msgpack::type::ARRAY;
126139
o.via.array.size = 2;

test/msgpack_cpp17.cpp

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -464,24 +464,25 @@ BOOST_AUTO_TEST_CASE(carray_byte_object_with_zone)
464464
#if defined(MSGPACK_USE_STD_VARIANT_ADAPTOR)
465465

466466
BOOST_AUTO_TEST_CASE(variant_pack_unpack_as) {
467-
std::stringstream ss;
468-
std::variant<bool, int, float, double> val1{1.0};
469-
msgpack::pack(ss, val1);
470-
std::string const& str = ss.str();
471-
msgpack::object_handle oh =
472-
msgpack::unpack(str.data(), str.size());
473-
std::variant<bool, int, float, double> val2 = oh.get().as<std::variant<bool, int, float, double> >();
474-
BOOST_CHECK(val1 == val2);
475-
BOOST_CHECK_THROW((oh.get().as<std::variant<bool>>()), msgpack::type_error);
467+
std::stringstream ss;
468+
std::variant<bool, int, float, double> val1{1.0};
469+
msgpack::pack(ss, val1);
470+
std::string const& str = ss.str();
471+
msgpack::object_handle oh =
472+
msgpack::unpack(str.data(), str.size());
473+
std::variant<bool, int, float, double> val2 =
474+
oh.get().as<std::variant<bool, int, float, double> >();
475+
BOOST_CHECK(val1 == val2);
476+
BOOST_CHECK_THROW((oh.get().as<std::variant<bool>>()), msgpack::type_error);
476477
}
477478

478479
BOOST_AUTO_TEST_CASE(variant_with_zone) {
479-
msgpack::zone z;
480-
std::variant<bool, int, float, double> val1{1.0};
481-
msgpack::object obj(val1, z);
482-
std::variant<bool, int, float, double> val2 = obj.as<std::variant<bool, int, float, double>>();
483-
BOOST_CHECK(val1 == val2);
484-
BOOST_CHECK_THROW((obj.as<std::variant<bool>>()), msgpack::type_error);
480+
msgpack::zone z;
481+
std::variant<bool, int, float, double> val1{1.0};
482+
msgpack::object obj(val1, z);
483+
std::variant<bool, int, float, double> val2 = obj.as<std::variant<bool, int, float, double>>();
484+
BOOST_CHECK(val1 == val2);
485+
BOOST_CHECK_THROW((obj.as<std::variant<bool>>()), msgpack::type_error);
485486
}
486487

487488
#endif // defined(MSGPACK_USE_STD_VARIANT_ADAPTOR)

0 commit comments

Comments
 (0)