feat(NODE-7139): remove pre-4.2 logic and deprecate dead code #4657
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
This PR removes the remaining unreachable code given our min supported wire version is 8. It also deprecates
ServerCapabilities
andReadPreference.minWireVersion
, which are publicly exposed but serve no real function in our current code base.Notes for Reviewers
ReadPreference.minWireVersion
was only ever set to 5, hence removing the corresponding commonWireVersion check in server selection is safe.What is the motivation for this change?
NODE-7139
Release Highlight
ServerCapabilities and ReadPreference.minWireVersion are deprecated
Neither the
ServerCapabilities
class nor theReadPreference.minWireVersion
property were ever intended for public use and, internally, are effectively dead code with the driver's minimum supported server version being 4.2.Double check the following
npm run check:lint
)type(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript