Skip to content

Commit fa4afda

Browse files
authored
Merge pull request #970 from mikepenz/feature/evaluate_jcenter_exodus
Remove library reliance on jcenter | limit sample app repositories
2 parents 1ea7a00 + 2882eb1 commit fa4afda

File tree

6 files changed

+57
-33
lines changed

6 files changed

+57
-33
lines changed

.github/workflows/ci.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,11 @@ jobs:
1717
with:
1818
fetch-depth: 100
1919

20+
- uses: actions/setup-java@v1
21+
with:
22+
java-version: '11'
23+
java-package: jdk
24+
2025
- name: Validate gradle wrapper
2126
uses: gradle/wrapper-validation-action@v1
2227

app/build.gradle

Lines changed: 25 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,26 @@ kapt {
6767
generateStubs = true
6868
}
6969

70+
repositories {
71+
maven {
72+
url "https://jitpack.io"
73+
content {
74+
includeGroup "com.github.MFlisar"
75+
includeGroup "com.github.turing-tech"
76+
}
77+
}
78+
maven {
79+
url "https://oss.sonatype.org/content/repositories/snapshots/"
80+
content { includeGroup "com.mikepenz.thirdparty" }
81+
}
82+
jcenter() {
83+
content {
84+
includeGroup "com.mopub"
85+
includeGroup "com.mopub.volley"
86+
}
87+
}
88+
}
89+
7090
dependencies {
7191
implementation 'androidx.multidex:multidex:2.0.1'
7292

@@ -145,16 +165,13 @@ dependencies {
145165

146166
//Used to async operations
147167
implementation 'io.reactivex.rxjava2:rxandroid:2.1.1'
148-
implementation 'io.reactivex.rxjava2:rxjava:2.2.20'
168+
implementation 'io.reactivex.rxjava2:rxjava:2.2.21'
149169

150170
compileOnly "com.google.code.findbugs:jsr305:3.0.2"
151171

152172
implementation "androidx.room:room-runtime:${versions.room}"
153173
kapt "androidx.room:room-compiler:${versions.room}"
154174

155-
implementation "androidx.lifecycle:lifecycle-extensions:${versions.lifecycle}"
156-
157-
158175
configurations.all {
159176
resolutionStrategy.force "com.mikepenz:iconics-core:${versions.iconics}"
160177
resolutionStrategy.force "com.mikepenz:iconics-views:${versions.iconics}"
@@ -169,10 +186,11 @@ dependencies {
169186

170187
buildscript {
171188
repositories {
172-
google()
173-
jcenter()
189+
mavenCentral()
190+
jcenter() { content { includeGroup "io.realm" } }
174191
}
192+
175193
dependencies {
176-
classpath "io.realm:realm-gradle-plugin:10.3.1"
194+
classpath "io.realm:realm-gradle-plugin:10.4.0"
177195
}
178196
}

app/src/main/java/com/mikepenz/fastadapter/app/PagedActivity.kt

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,7 @@ package com.mikepenz.fastadapter.app
33
import android.os.Bundle
44
import android.os.Handler
55
import androidx.appcompat.app.AppCompatActivity
6-
import androidx.lifecycle.Observer
7-
import androidx.lifecycle.ViewModelProviders
8-
import androidx.paging.PagedList
6+
import androidx.lifecycle.ViewModelProvider
97
import androidx.recyclerview.widget.AsyncDifferConfig
108
import androidx.recyclerview.widget.DiffUtil
119
import androidx.recyclerview.widget.LinearLayoutManager
@@ -69,12 +67,11 @@ class PagedActivity : AppCompatActivity() {
6967
binding.rv.layoutManager = LinearLayoutManager(this)
7068
binding.rv.adapter = mFastAdapter
7169

72-
val viewModel = ViewModelProviders.of(this,
73-
DemoEntityViewModel.DemoEntityViewModelFactory(this.application))
74-
.get(DemoEntityViewModel::class.java)
70+
val viewModel = ViewModelProvider(this, DemoEntityViewModel.DemoEntityViewModelFactory(this.application))
71+
.get(DemoEntityViewModel::class.java)
7572

7673
//listen to data changes and pass it to adapter for displaying in recycler view
77-
viewModel.demoEntitiesList.observe(this, Observer<PagedList<DemoEntity>> { t -> mItemAdapter.submitList(t!!) })
74+
viewModel.demoEntitiesList.observe(this, { t -> mItemAdapter.submitList(t!!) })
7875

7976
//if we do this. the first added items will be animated :D
8077
Handler().postDelayed({

build.gradle

Lines changed: 21 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ buildscript {
99
]
1010

1111
setup = [
12-
gradleTools: '4.1.2',
12+
gradleTools: '4.1.3',
1313
compileSdk : 30,
1414
buildTools : "30.0.2",
1515
minSdk : 16,
@@ -18,31 +18,28 @@ buildscript {
1818

1919
versions = [
2020
androidX : '1.1.0',
21-
recyclerView : '1.1.0',
21+
recyclerView : '1.2.0',
2222
material : '1.3.0',
2323
appcompat : '1.2.0',
2424
drawerlayout : '1.1.0',
2525
constraintLayout: '2.0.4',
2626
cardview : '1.0.0',
27-
kotlin : '1.4.30',
28-
iconics : '5.2.5',
29-
materialdrawer : '8.3.1',
30-
aboutlib : '8.8.1',
27+
kotlin : '1.4.32',
28+
iconics : '5.2.8',
29+
materialdrawer : '8.4.0',
30+
aboutlib : '8.8.4',
3131
roboelectric : '4.5.1',
32-
detekt : '1.15.0',
32+
detekt : '1.16.0',
3333
paging : "2.1.2",
3434
room : "2.2.6",
35-
lifecycle : "2.2.0"
35+
lifecycle : "2.3.1"
3636
]
3737
}
3838

3939
repositories {
40-
google()
40+
gradlePluginPortal()
4141
mavenCentral()
42-
jcenter()
43-
maven {
44-
url "https://plugins.gradle.org/m2/"
45-
}
42+
google()
4643
}
4744
dependencies {
4845
classpath "com.android.tools.build:gradle:${setup.gradleTools}"
@@ -56,12 +53,18 @@ allprojects {
5653
group "com.mikepenz"
5754

5855
repositories {
59-
google()
6056
mavenCentral()
61-
jcenter()
62-
maven { url "https://oss.sonatype.org/content/repositories/snapshots/" }
63-
maven { url "https://jitpack.io" }
64-
maven { url "https://dl.bintray.com/mikepenz/maven" }
57+
google()
58+
maven {
59+
// (mp) remove when available on maven center
60+
url "https://maven.pkg.jetbrains.space/public/p/kotlinx-html/maven"
61+
content { includeGroup "org.jetbrains.kotlinx" }
62+
}
63+
}
64+
65+
configurations.all {
66+
resolutionStrategy.force "org.jetbrains.kotlinx:kotlinx-html-jvm:0.7.3"
67+
// (mp) remove when available on maven center
6568
}
6669
}
6770

gradle.properties

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ POM_LICENCE_URL=http://www.apache.org/licenses/LICENSE-2.0.txt
1616
POM_LICENCE_DIST=repo
1717
POM_DEVELOPER_ID=mikepenz
1818
POM_DEVELOPER_NAME=Mike Penz
19+
1920
android.useAndroidX=true
2021
android.enableJetifier=true
2122
org.gradle.jvmargs=-Xmx4G
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
3-
distributionUrl=https\://services.gradle.org/distributions/gradle-6.8.2-all.zip
3+
distributionUrl=https\://services.gradle.org/distributions/gradle-6.8.3-all.zip
44
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists

0 commit comments

Comments
 (0)