Skip to content

Commit 269c3c6

Browse files
ryfu-msftryfu-msft
authored
Binskim error EnableCriticalCompilerWarnings (#4764)
Fixes a binskim error where sfsclient dependencies (curl -> ares) were not getting compiled with a warning level > 3 compiler flag. Added `/W3` to only the release triplets Verified that of WindowsPackageManager.dll no longer shows an error when running with binskim.
1 parent 5010482 commit 269c3c6

File tree

8 files changed

+16
-16
lines changed

8 files changed

+16
-16
lines changed

‎src/VcpkgCustomTriplets/arm-release-static.cmake‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
set(VCPKG_TARGET_ARCHITECTURE arm)
22
set(VCPKG_CRT_LINKAGE static)
33
set(VCPKG_LIBRARY_LINKAGE static)
4-
set(VCPKG_C_FLAGS "/Qspectre")
5-
set(VCPKG_CXX_FLAGS "/Qspectre")
4+
set(VCPKG_C_FLAGS "/Qspectre /W3")
5+
set(VCPKG_CXX_FLAGS "/Qspectre /W3")
66
set(VCPKG_BUILD_TYPE release)

‎src/VcpkgCustomTriplets/arm-release.cmake‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
set(VCPKG_TARGET_ARCHITECTURE arm)
22
set(VCPKG_CRT_LINKAGE dynamic)
33
set(VCPKG_LIBRARY_LINKAGE static)
4-
set(VCPKG_C_FLAGS "/Qspectre")
5-
set(VCPKG_CXX_FLAGS "/Qspectre")
4+
set(VCPKG_C_FLAGS "/Qspectre /W3")
5+
set(VCPKG_CXX_FLAGS "/Qspectre /W3")
66
set(VCPKG_BUILD_TYPE release)

‎src/VcpkgCustomTriplets/arm64-release-static.cmake‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
set(VCPKG_TARGET_ARCHITECTURE arm64)
22
set(VCPKG_CRT_LINKAGE static)
33
set(VCPKG_LIBRARY_LINKAGE static)
4-
set(VCPKG_C_FLAGS "/Qspectre")
5-
set(VCPKG_CXX_FLAGS "/Qspectre")
4+
set(VCPKG_C_FLAGS "/Qspectre /W3")
5+
set(VCPKG_CXX_FLAGS "/Qspectre /W3")
66
set(VCPKG_BUILD_TYPE release)

‎src/VcpkgCustomTriplets/arm64-release.cmake‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
set(VCPKG_TARGET_ARCHITECTURE arm64)
22
set(VCPKG_CRT_LINKAGE dynamic)
33
set(VCPKG_LIBRARY_LINKAGE static)
4-
set(VCPKG_C_FLAGS "/Qspectre")
5-
set(VCPKG_CXX_FLAGS "/Qspectre")
4+
set(VCPKG_C_FLAGS "/Qspectre /W3")
5+
set(VCPKG_CXX_FLAGS "/Qspectre /W3")
66
set(VCPKG_BUILD_TYPE release)

‎src/VcpkgCustomTriplets/x64-release-static.cmake‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
set(VCPKG_TARGET_ARCHITECTURE x64)
22
set(VCPKG_CRT_LINKAGE static)
33
set(VCPKG_LIBRARY_LINKAGE static)
4-
set(VCPKG_C_FLAGS "/Qspectre")
5-
set(VCPKG_CXX_FLAGS "/Qspectre")
4+
set(VCPKG_C_FLAGS "/Qspectre /W3")
5+
set(VCPKG_CXX_FLAGS "/Qspectre /W3")
66
set(VCPKG_BUILD_TYPE release)

‎src/VcpkgCustomTriplets/x64-release.cmake‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
set(VCPKG_TARGET_ARCHITECTURE x64)
22
set(VCPKG_CRT_LINKAGE dynamic)
33
set(VCPKG_LIBRARY_LINKAGE static)
4-
set(VCPKG_C_FLAGS "/Qspectre")
5-
set(VCPKG_CXX_FLAGS "/Qspectre")
4+
set(VCPKG_C_FLAGS "/Qspectre /W3")
5+
set(VCPKG_CXX_FLAGS "/Qspectre /W3")
66
set(VCPKG_BUILD_TYPE release)

‎src/VcpkgCustomTriplets/x86-release-static.cmake‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
set(VCPKG_TARGET_ARCHITECTURE x86)
22
set(VCPKG_CRT_LINKAGE static)
33
set(VCPKG_LIBRARY_LINKAGE static)
4-
set(VCPKG_C_FLAGS "/Qspectre")
5-
set(VCPKG_CXX_FLAGS "/Qspectre")
4+
set(VCPKG_C_FLAGS "/Qspectre /W3")
5+
set(VCPKG_CXX_FLAGS "/Qspectre /W3")
66
set(VCPKG_BUILD_TYPE release)

‎src/VcpkgCustomTriplets/x86-release.cmake‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
set(VCPKG_TARGET_ARCHITECTURE x86)
22
set(VCPKG_CRT_LINKAGE dynamic)
33
set(VCPKG_LIBRARY_LINKAGE static)
4-
set(VCPKG_C_FLAGS "/Qspectre")
5-
set(VCPKG_CXX_FLAGS "/Qspectre")
4+
set(VCPKG_C_FLAGS "/Qspectre /W3")
5+
set(VCPKG_CXX_FLAGS "/Qspectre /W3")
66
set(VCPKG_BUILD_TYPE release)

0 commit comments

Comments
 (0)