Skip to content

Commit fa6188b

Browse files
authored
Rename editor.inlineSuggest.experimental.triggerCommandOnProviderChange to editor.inlineSuggest.triggerCommandOnProviderChange (#265322)
1 parent 8c6fe48 commit fa6188b

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

src/vs/editor/common/config/editorOptions.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4388,6 +4388,11 @@ export interface IInlineSuggestOptions {
43884388
enabled?: boolean;
43894389
};
43904390

4391+
/**
4392+
* @internal
4393+
*/
4394+
triggerCommandOnProviderChange?: boolean;
4395+
43914396
/**
43924397
* @internal
43934398
*/
@@ -4397,11 +4402,6 @@ export interface IInlineSuggestOptions {
43974402
*/
43984403
suppressInlineSuggestions?: string;
43994404

4400-
/**
4401-
* @internal
4402-
*/
4403-
triggerCommandOnProviderChange?: boolean;
4404-
44054405
showOnSuggestConflict?: 'always' | 'never' | 'whenSuggestListIsIncomplete';
44064406
};
44074407
}
@@ -4435,9 +4435,9 @@ class InlineEditorSuggest extends BaseEditorOption<EditorOption.inlineSuggest, I
44354435
renderSideBySide: 'auto',
44364436
allowCodeShifting: 'always',
44374437
},
4438+
triggerCommandOnProviderChange: false,
44384439
experimental: {
44394440
suppressInlineSuggestions: '',
4440-
triggerCommandOnProviderChange: false,
44414441
showOnSuggestConflict: 'never',
44424442
},
44434443
};
@@ -4487,9 +4487,9 @@ class InlineEditorSuggest extends BaseEditorOption<EditorOption.inlineSuggest, I
44874487
mode: 'auto'
44884488
}
44894489
},
4490-
'editor.inlineSuggest.experimental.triggerCommandOnProviderChange': {
4490+
'editor.inlineSuggest.triggerCommandOnProviderChange': {
44914491
type: 'boolean',
4492-
default: defaults.experimental.triggerCommandOnProviderChange,
4492+
default: defaults.triggerCommandOnProviderChange,
44934493
tags: ['experimental'],
44944494
description: nls.localize('inlineSuggest.triggerCommandOnProviderChange', "Controls whether to trigger a command when the inline suggestion provider changes."),
44954495
experiment: {
@@ -4559,9 +4559,9 @@ class InlineEditorSuggest extends BaseEditorOption<EditorOption.inlineSuggest, I
45594559
allowCodeShifting: stringSet(input.edits?.allowCodeShifting, this.defaultValue.edits.allowCodeShifting, ['always', 'horizontal', 'never']),
45604560
renderSideBySide: stringSet(input.edits?.renderSideBySide, this.defaultValue.edits.renderSideBySide, ['never', 'auto']),
45614561
},
4562+
triggerCommandOnProviderChange: boolean(input.triggerCommandOnProviderChange, this.defaultValue.triggerCommandOnProviderChange),
45624563
experimental: {
45634564
suppressInlineSuggestions: EditorStringOption.string(input.experimental?.suppressInlineSuggestions, this.defaultValue.experimental.suppressInlineSuggestions),
4564-
triggerCommandOnProviderChange: boolean(input.experimental?.triggerCommandOnProviderChange, this.defaultValue.experimental.triggerCommandOnProviderChange),
45654565
showOnSuggestConflict: stringSet(input.experimental?.showOnSuggestConflict, this.defaultValue.experimental.showOnSuggestConflict, ['always', 'never', 'whenSuggestListIsIncomplete']),
45664566
},
45674567
};

src/vs/editor/contrib/inlineCompletions/browser/model/inlineCompletionsModel.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ export class InlineCompletionsModel extends Disposable {
131131
this._suppressedInlineCompletionGroupIds = inlineSuggest.map(v => new Set(v.experimental.suppressInlineSuggestions.split(',')));
132132
this._inlineEditsEnabled = inlineSuggest.map(v => !!v.edits.enabled);
133133
this._inlineEditsShowCollapsedEnabled = inlineSuggest.map(s => s.edits.showCollapsed);
134-
this._triggerCommandOnProviderChange = inlineSuggest.map(s => s.experimental.triggerCommandOnProviderChange);
134+
this._triggerCommandOnProviderChange = inlineSuggest.map(s => s.triggerCommandOnProviderChange);
135135
this._minShowDelay = inlineSuggest.map(s => s.minShowDelay);
136136
this._showOnSuggestConflict = inlineSuggest.map(s => s.experimental.showOnSuggestConflict);
137137

0 commit comments

Comments
 (0)