From 8a426827c18d0d21a9d8a67bf316d6bd9ff545d0 Mon Sep 17 00:00:00 2001 From: Nicole Mazzuca Date: Mon, 19 Dec 2022 16:02:46 -0800 Subject: [PATCH 1/2] add transition comment to `ios_base::hexfloat` --- stl/inc/xiosbase | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/stl/inc/xiosbase b/stl/inc/xiosbase index 342e68360ed..d8e0d1bf98a 100644 --- a/stl/inc/xiosbase +++ b/stl/inc/xiosbase @@ -44,7 +44,7 @@ public: static constexpr _Fmtflags scientific = static_cast<_Fmtflags>(0x1000); static constexpr _Fmtflags fixed = static_cast<_Fmtflags>(0x2000); - static constexpr _Fmtflags hexfloat = static_cast<_Fmtflags>(0x3000); // added with TR1 (not in C++11) + static constexpr _Fmtflags hexfloat = static_cast<_Fmtflags>(0x3000); // TRANSITION, ABI static constexpr _Fmtflags boolalpha = static_cast<_Fmtflags>(0x4000); static constexpr _Fmtflags _Stdio = static_cast<_Fmtflags>(0x8000); @@ -124,7 +124,7 @@ template const typename _Iosb<_Dummy>::_Fmtflags _Iosb<_Dummy>::fixed; template -const typename _Iosb<_Dummy>::_Fmtflags _Iosb<_Dummy>::hexfloat; // added with TR1 (not in C++11) +const typename _Iosb<_Dummy>::_Fmtflags _Iosb<_Dummy>::hexfloat; // TRANSITION, ABI template const typename _Iosb<_Dummy>::_Fmtflags _Iosb<_Dummy>::boolalpha; From 80ccd0f56953fb61ca22f5fc4ce755394c1f85f8 Mon Sep 17 00:00:00 2001 From: nicole mazzuca <83086508+strega-nil-ms@users.noreply.github.com> Date: Tue, 20 Dec 2022 20:47:18 -0800 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: Alex Guteniev --- stl/inc/xiosbase | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/stl/inc/xiosbase b/stl/inc/xiosbase index d8e0d1bf98a..87d17875fd1 100644 --- a/stl/inc/xiosbase +++ b/stl/inc/xiosbase @@ -44,7 +44,7 @@ public: static constexpr _Fmtflags scientific = static_cast<_Fmtflags>(0x1000); static constexpr _Fmtflags fixed = static_cast<_Fmtflags>(0x2000); - static constexpr _Fmtflags hexfloat = static_cast<_Fmtflags>(0x3000); // TRANSITION, ABI + static constexpr _Fmtflags hexfloat = static_cast<_Fmtflags>(0x3000); // TRANSITION, ABI, GH-3296 static constexpr _Fmtflags boolalpha = static_cast<_Fmtflags>(0x4000); static constexpr _Fmtflags _Stdio = static_cast<_Fmtflags>(0x8000); @@ -124,7 +124,7 @@ template const typename _Iosb<_Dummy>::_Fmtflags _Iosb<_Dummy>::fixed; template -const typename _Iosb<_Dummy>::_Fmtflags _Iosb<_Dummy>::hexfloat; // TRANSITION, ABI +const typename _Iosb<_Dummy>::_Fmtflags _Iosb<_Dummy>::hexfloat; // TRANSITION, ABI, GH-3296 template const typename _Iosb<_Dummy>::_Fmtflags _Iosb<_Dummy>::boolalpha;