fix heap-use-after-free for _HAS_EXCEPTIONS=0

Author: wolframw

stl/inc/chrono

@@ -1725,9 +1725,15 @@ namespace chrono {
 
     _EXPORT_STD class _NODISCARD nonexistent_local_time : public runtime_error {
     public:
+#if _HAS_EXCEPTIONS
         template <class _Duration>
         nonexistent_local_time(const local_time<_Duration>& _Tp, const local_info& _Info)
             : runtime_error(_Make_string(_Tp, _Info)) {}
+#else
+        template <class _Duration>
+        nonexistent_local_time(const local_time<_Duration>&, const local_info&)
+            : runtime_error("nonexistent local time") {}
+#endif
 
     private:
         template <class _Duration>
@@ -1741,9 +1747,15 @@ namespace chrono {
 
     _EXPORT_STD class _NODISCARD ambiguous_local_time : public runtime_error {
     public:
+#if _HAS_EXCEPTIONS
         template <class _Duration>
         ambiguous_local_time(const local_time<_Duration>& _Tp, const local_info& _Info)
             : runtime_error(_Make_string(_Tp, _Info)) {}
+#else
+        template <class _Duration>
+        ambiguous_local_time(const local_time<_Duration>&, const local_info&)
+            : runtime_error("ambiguous local time") {}
+#endif
 
     private:
         template <class _Duration>

stl/inc/system_error

@@ -470,10 +470,17 @@ private:
     }
 
 protected:
+#if _HAS_EXCEPTIONS
     _System_error(error_code _Errcode) : runtime_error(_Errcode.message()), _Mycode(_Errcode) {}
 
     _System_error(error_code _Errcode, const string& _Message)
         : runtime_error(_Makestr(_Errcode, _Message)), _Mycode(_Errcode) {}
+#else
+    _System_error(error_code _Errcode) : runtime_error("system error"), _Mycode(_Errcode) {}
+
+    _System_error(error_code _Errcode, const string&)
+        : runtime_error("system error"), _Mycode(_Errcode) {}
+#endif
 
     error_code _Mycode; // the stored error code
 };

tests/std/tests/GH_005276_system_error_heap-use-after-free/env.lst

@@ -0,0 +1,6 @@
+# Copyright (c) Microsoft Corporation.
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+
+RUNALL_INCLUDE ..\usual_20_matrix.lst
+RUNALL_CROSSLIST
+*	PM_CL="/D_HAS_EXCEPTIONS=0"

tests/std/tests/GH_005276_system_error_heap-use-after-free/test.cpp

@@ -0,0 +1,22 @@
+// Copyright (c) Microsoft Corporation.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+
+#include <cstdio>
+#include <chrono>
+#include <string>
+#include <system_error>
+using namespace std;
+using namespace chrono;
+
+int main() {
+    string str{"abc"};
+    error_code ec{2, system_category()};
+    system_error syserr{ec};
+
+    ambiguous_local_time alt{local_time<seconds>{}, local_info{}};
+
+    nonexistent_local_time nlt{local_time<seconds>{}, local_info{}};
+
+    printf("%s\n%s\n%s\n", syserr.what(), alt.what(), nlt.what());
+}
+