fix: close resp body (#3364)

testwill · web-flow · commit 5216e74b9ade · 2024-08-03T21:20:43.000+02:00
### Pull Request Checklist  * [ ] I have added Go unit tests or [Complement integration tests](https://github.com/matrix-org/complement) for this PR _or_ I have justified why this PR doesn't need tests * [ ] Pull request includes a [sign off below using a legally identifiable name](https://matrix-org.github.io/dendrite/development/contributing#sign-off) _or_ I have already signed off privately Signed-off-by: `Your Name <your@email.example.org>` Signed-off-by: guoguangwu <guoguangwug@gmail.com>
diff --git a/clientapi/threepid/threepid.go b/clientapi/threepid/threepid.go
@@ -83,6 +83,7 @@ func CreateSession(
 	if err != nil {
 		return "", err
 	}
+	defer resp.Body.Close()
 
 	// Error if the status isn't OK
 	if resp.StatusCode != http.StatusOK {

Original file line number	Diff line number	Diff line change
`@@ -83,6 +83,7 @@ func CreateSession(`
`83`	`83`	`if err != nil {`
`84`	`84`	`return "", err`
`85`	`85`	`}`
	`86`	`+ defer resp.Body.Close()`
`86`	`87`
`87`	`88`	`// Error if the status isn't OK`
`88`	`89`	`if resp.StatusCode != http.StatusOK {`