_scalac attributes list

Author: mateuszkuta256

scala/private/common_attributes.bzl

@@ -8,6 +8,8 @@ load(
     "@io_bazel_rules_scala//scala:plusone.bzl",
     _collect_plus_one_deps_aspect = "collect_plus_one_deps_aspect",
 )
+load("//scala/versions:versions.bzl", "sanitize_version")
+load("@io_bazel_rules_scala_config//:config.bzl", "SCALA_VERSIONS")
 
 common_attrs_for_plugin_bootstrapping = {
     "srcs": attr.label_list(allow_files = [
@@ -84,35 +86,10 @@ implicit_deps = {
     "_java_runtime": attr.label(
         default = Label("@bazel_tools//tools/jdk:current_java_runtime"),
     ),
-    "_scalac": attr.label(
-        executable = True,
-        cfg = "exec",
-        default = Label("@io_bazel_rules_scala//src/java/io/bazel/rulesscala/scalac"),
-        allow_files = True,
-    ),
-    "_scalac_before_2_12_13": attr.label(
-        executable = True,
-        cfg = "exec",
-        default = Label("@io_bazel_rules_scala//src/java/io/bazel/rulesscala/scalac:scalac_before_2_12_13"),
-        allow_files = True,
-    ),
-    "_scalac_after_2_12_13_and_before_2_13_12": attr.label(
-        executable = True,
-        cfg = "exec",
-        default = Label("@io_bazel_rules_scala//src/java/io/bazel/rulesscala/scalac:scalac_after_2_12_13_and_before_2_13_12"),
-        allow_files = True,
-    ),
-    "_scalac_after_2_13_12": attr.label(
-        executable = True,
-        cfg = "exec",
-        default = Label("@io_bazel_rules_scala//src/java/io/bazel/rulesscala/scalac:scalac_after_2_13_12"),
-        allow_files = True,
-    ),
-    "_scalac_3": attr.label(
-        executable = True,
-        cfg = "exec",
-        default = Label("@io_bazel_rules_scala//src/java/io/bazel/rulesscala/scalac:scalac_3"),
-        allow_files = True,
+    "_scalac": attr.label_list(
+        default = [
+            Label("@io_bazel_rules_scala//src/java/io/bazel/rulesscala/scalac"),
+        ] + [Label("@io_bazel_rules_scala//src/java/io/bazel/rulesscala/scalac:scalac_" + sanitize_version(version)) for version in SCALA_VERSIONS],
     ),
     "_exe": attr.label(
         executable = True,

scala/private/macros/setup_scala_toolchain.bzl

@@ -160,7 +160,6 @@ def setup_scala_toolchain(
 
     scala_toolchain(
         name = "%s_impl" % name,
-        scala_version = scala_version,
         dep_providers = dep_providers,
         enable_semanticdb = enable_semanticdb,
         visibility = visibility,

scala/private/phases/phase_compile.bzl

@@ -19,6 +19,7 @@ load(
 load(":resources.bzl", _resource_paths = "paths")
 load("@io_bazel_rules_scala_config//:config.bzl", "SCALA_VERSION")
 load("@io_bazel_rules_scala//scala:scala_cross_version.bzl", "extract_major_version", "extract_minor_version")
+load("//scala/versions:versions.bzl", "sanitize_version")
 
 buildijar_default_value = True if SCALA_VERSION.startswith("2.") else False
 
@@ -392,16 +393,9 @@ def _interim_java_provider_for_java_compilation(scala_output):
     )
 
 def _select_scalac(ctx):
-    scala_version = ctx.toolchains["@io_bazel_rules_scala//scala:toolchain_type"].scala_version
-    if scala_version:
-        major_version = extract_major_version(scala_version)
-        minor_version = extract_minor_version(scala_version)
-        if major_version.startswith("2.11") or (major_version.startswith("2.12") and int(minor_version) < 13):
-            return ctx.executable._scalac_before_2_12_13
-        if ((major_version.startswith("2.12") and int(minor_version) >= 13) or (major_version.startswith("2.13") and int(minor_version) < 12)):
-            return ctx.executable._scalac_after_2_12_13_and_before_2_13_12
-        if (major_version.startswith("2.13") and int(minor_version) >= 12):
-            return ctx.executable._scalac_after_2_13_12
-        if (major_version.startswith("3")):
-            return ctx.executable._scalac_3
-    return ctx.executable._scalac
+    if hasattr(ctx.attr, "scala_version"):
+        version_suffix = sanitize_version(ctx.attr.scala_version)
+        for scalac in ctx.attr._scalac:
+            if scalac.label.name.endswith(version_suffix):
+                return scalac.files_to_run
+    return ctx.attr._scalac[0].files_to_run

scala/private/rules/scala_library.bzl

@@ -173,11 +173,10 @@ _scala_library_for_plugin_bootstrapping_attrs.update(implicit_deps)
 # which does not contain plugin related attributes, and thus avoids the cyclic dependency issue
 _scala_library_for_plugin_bootstrapping_attrs.update({
     "build_ijar": attr.bool(default = True),
-    "_scalac": attr.label(
-        executable = True,
-        cfg = "exec",
-        default = Label("@io_bazel_rules_scala//src/java/io/bazel/rulesscala/scalac:scalac_bootstrap"),
-        allow_files = True,
+    "_scalac": attr.label_list(
+        default = [
+            Label("@io_bazel_rules_scala//src/java/io/bazel/rulesscala/scalac:scalac_bootstrap"),
+        ],
     ),
 })
 

scala/scala_toolchain.bzl

@@ -101,7 +101,6 @@ def _scala_toolchain_impl(ctx):
         enable_semanticdb = ctx.attr.enable_semanticdb,
         semanticdb_bundle_in_jar = ctx.attr.semanticdb_bundle_in_jar,
         use_argument_file_in_runner = ctx.attr.use_argument_file_in_runner,
-        scala_version = ctx.attr.scala_version,
     )
     return [toolchain]
 
@@ -174,7 +173,6 @@ scala_toolchain = rule(
             default = False,
             doc = "Changes java binaries scripts (including tests) to use argument files and not classpath jars to improve performance, requires java > 8",
         ),
-        "scala_version": attr.string(),
     },
     fragments = ["java"],
 )

src/java/io/bazel/rulesscala/scalac/BUILD

@@ -28,63 +28,7 @@ java_binary(
     ],
     main_class = "io.bazel.rulesscala.scalac.ScalacWorker",
     visibility = ["//visibility:public"],
-    deps = DEP_REPORTING_DEPS + SCALAC_DEPS + ["//src/java/io/bazel/rulesscala/scalac/reporter:reporter"],
-)
-
-java_binary(
-    name = "scalac_before_2_12_13",
-    srcs = [
-        ":scalac2_files",
-    ],
-    javacopts = [
-        "-source 1.8",
-        "-target 1.8",
-    ],
-    main_class = "io.bazel.rulesscala.scalac.ScalacWorker",
-    visibility = ["//visibility:public"],
-    deps = SCALAC_DEPS + ["//src/java/io/bazel/rulesscala/scalac/reporter:reporter_before_2_12_13"],
-)
-
-java_binary(
-    name = "scalac_after_2_12_13_and_before_2_13_12",
-    srcs = [
-        ":scalac2_files",
-    ],
-    javacopts = [
-        "-source 1.8",
-        "-target 1.8",
-    ],
-    main_class = "io.bazel.rulesscala.scalac.ScalacWorker",
-    visibility = ["//visibility:public"],
-    deps = SCALAC_DEPS + ["//src/java/io/bazel/rulesscala/scalac/reporter:reporter_after_2_12_13_and_before_2_13_12"],
-)
-
-java_binary(
-    name = "scalac_after_2_13_12",
-    srcs = [
-        ":scalac2_files",
-    ],
-    javacopts = [
-        "-source 1.8",
-        "-target 1.8",
-    ],
-    main_class = "io.bazel.rulesscala.scalac.ScalacWorker",
-    visibility = ["//visibility:public"],
-    deps = SCALAC_DEPS + ["//src/java/io/bazel/rulesscala/scalac/reporter:reporter_after_2_13_12"],
-)
-
-java_binary(
-    name = "scalac_3",
-    srcs = [
-        ":scalac3_files",
-    ],
-    javacopts = [
-        "-source 1.8",
-        "-target 1.8",
-    ],
-    main_class = "io.bazel.rulesscala.scalac.ScalacWorker",
-    visibility = ["//visibility:public"],
-    deps = SCALAC_DEPS + ["//src/java/io/bazel/rulesscala/scalac/reporter:reporter_3"],
+    deps = DEP_REPORTING_DEPS + SCALAC_DEPS + ["//src/java/io/bazel/rulesscala/scalac/reporter"],
 )
 
 java_binary(
@@ -98,14 +42,14 @@ java_binary(
     ],
     main_class = "io.bazel.rulesscala.scalac.ScalacWorker",
     visibility = ["//visibility:public"],
-    deps = SCALAC_DEPS + ["//src/java/io/bazel/rulesscala/scalac/reporter:reporter"],
+    deps = SCALAC_DEPS + ["//src/java/io/bazel/rulesscala/scalac/reporter"],
 )
 
 filegroup(
     name = "scalac_files",
     srcs = [
-        "ScalacWorker.java",
         "ScalacInvokerResults.java",
+        "ScalacWorker.java",
     ] + (
         [
             "ScalacInvoker.java",
@@ -115,21 +59,6 @@ filegroup(
     visibility = ["//visibility:public"],
 )
 
-filegroup(
-    name = "scalac2_files",
-    srcs = [
-        "ReportableMainClass.java",
-        "ScalacInvoker.java",
-        "ScalacInvokerResults.java",
-        "ScalacWorker.java",
-    ],
-)
+load("//src/java/io/bazel/rulesscala/scalac:scalac.bzl", "setup_scalac")
 
-filegroup(
-    name = "scalac3_files",
-    srcs = [
-        "ScalacInvoker3.java",
-        "ScalacInvokerResults.java",
-        "ScalacWorker.java",
-    ],
-)
+setup_scalac()

src/java/io/bazel/rulesscala/scalac/reporter/BUILD

@@ -23,6 +23,7 @@ java_library(
     ],
 )
 
+#TODO prod version will register reporters automatically in a loop (SCALA_VERSIONS)
 java_library(
     name = "reporter_before_2_12_13",
     srcs = [

src/java/io/bazel/rulesscala/scalac/scalac.bzl

@@ -0,0 +1,56 @@
+load("@rules_java//java:defs.bzl", "java_binary", "java_library")
+load("//scala/versions:versions.bzl", "sanitize_version")
+load("@io_bazel_rules_scala_config//:config.bzl", "SCALA_VERSIONS")
+load("@io_bazel_rules_scala//scala:scala_cross_version.bzl", "extract_major_version", "extract_minor_version")
+
+def setup_scalac():
+    for scala_version in SCALA_VERSIONS:
+        _scalac(scala_version)
+
+def _scalac(scala_version):
+    scala_major_version = extract_major_version(scala_version)
+    scala_minor_version = extract_minor_version(scala_version)
+    version_suffix = "_" + sanitize_version(scala_version)
+
+    java_binary(
+        name = "scalac" + version_suffix,
+        srcs = _scalac_srcs(scala_version),
+        main_class = "io.bazel.rulesscala.scalac.ScalacWorker",
+        visibility = ["//visibility:public"],
+        javacopts = [
+            "-source 1.8",
+            "-target 1.8",
+        ],
+        deps = [
+            _reporter(scala_major_version, scala_minor_version),
+            "//scala/private/toolchain_deps:scala_compile_classpath",
+            "//src/java/io/bazel/rulesscala/io_utils",
+            "@bazel_tools//src/main/protobuf:worker_protocol_java_proto",
+            "@io_bazel_rules_scala//src/java/io/bazel/rulesscala/jar",
+            "@io_bazel_rules_scala//src/java/io/bazel/rulesscala/worker",
+            "@io_bazel_rules_scala//src/protobuf/io/bazel/rules_scala:diagnostics_java_proto",
+            "//src/java/io/bazel/rulesscala/scalac/compileoptions",
+        ],
+    )
+
+def _reporter(scala_major_version, scala_minor_version):
+    if (scala_major_version == "2.11") or (scala_major_version == "2.12" and int(scala_minor_version) < 13):
+        return "//src/java/io/bazel/rulesscala/scalac/reporter:reporter_before_2_12_13"
+    elif (scala_major_version == "2.12" and int(scala_minor_version) >= 13) or (scala_major_version == "2.13" and int(scala_minor_version) < 12):
+        return "//src/java/io/bazel/rulesscala/scalac/reporter:reporter_after_2_12_13_and_before_2_13_12"
+    elif (scala_major_version == "2.13" and int(scala_minor_version) >= 12):
+        return "//src/java/io/bazel/rulesscala/scalac/reporter:reporter_after_2_13_12"
+    else:
+        return "//src/java/io/bazel/rulesscala/scalac/reporter:reporter_3"
+
+def _scalac_srcs(scala_version):
+    return [
+        "ReportableMainClass.java",
+        "ScalacInvoker.java",
+        "ScalacInvokerResults.java",
+        "ScalacWorker.java",
+    ] if scala_version.startswith("2") else [
+        "ScalacInvoker3.java",
+        "ScalacInvokerResults.java",
+        "ScalacWorker.java",
+    ]