test: add tests for custom rule group intervals

Specific ones and general/specific combined

Author: wbollock

internal/prometheus/storage_test.go

@@ -4,6 +4,7 @@ import (
 	"bytes"
 	"context"
 	"testing"
+	"time"
 
 	"github.com/prometheus/prometheus/model/rulefmt"
 	"github.com/stretchr/testify/assert"
@@ -12,7 +13,29 @@ import (
 	"github.com/slok/sloth/internal/prometheus"
 )
 
+func parseDuration(durationStr string, t *testing.T) time.Duration {
+	duration, err := time.ParseDuration(durationStr)
+	if err != nil {
+		t.Errorf("could not parse duration: %v", err)
+		return 0
+	}
+	return duration
+}
+
 func TestIOWriterGroupedRulesYAMLRepoStore(t *testing.T) {
+	// set intervals ahead of time
+	ruleGroupInterval := parseDuration("2m", t)
+	// 0s = default/blank
+	ruleGroupIntervalBlank := parseDuration("0s", t)
+	// A/B for multiple group test
+	ruleGroupIntervalA := parseDuration("3m", t)
+	ruleGroupIntervalB := parseDuration("1h", t)
+	// for individual settings
+	sliErrorRulesInterval := parseDuration("4m", t)
+	metadataRulesInterval := parseDuration("5m", t)
+	alertRulesInterval := parseDuration("6m", t)
+	// need test for mix of rulegroupinterval and individual
+
 	tests := map[string]struct {
 		slos    []prometheus.StorageSLO
 		expYAML string
@@ -30,10 +53,11 @@ func TestIOWriterGroupedRulesYAMLRepoStore(t *testing.T) {
 			expErr: true,
 		},
 
-		"Having a single SLI recording rule should render correctly.": {
+		"Having a single SLI recording rule with the generic rule_group interval should render correctly.": {
+
 			slos: []prometheus.StorageSLO{
 				{
-					SLO: prometheus.SLO{ID: "test1", RuleGroupInterval: "2m"},
+					SLO: prometheus.SLO{ID: "test1", RuleGroupInterval: ruleGroupInterval},
 					Rules: prometheus.SLORules{
 						SLIErrorRecRules: []rulefmt.Rule{
 							{
@@ -92,7 +116,7 @@ groups:
 		"Having a single SLO alert rule should render correctly.": {
 			slos: []prometheus.StorageSLO{
 				{
-					SLO: prometheus.SLO{ID: "test1", RuleGroupInterval: "2m"},
+					SLO: prometheus.SLO{ID: "test1", RuleGroupInterval: ruleGroupInterval},
 					Rules: prometheus.SLORules{
 						AlertRules: []rulefmt.Rule{
 							{
@@ -125,7 +149,7 @@ groups:
 		"Having a single a blank or empty rule_group interval render correctly.": {
 			slos: []prometheus.StorageSLO{
 				{
-					SLO: prometheus.SLO{ID: "test1", RuleGroupInterval: ""},
+					SLO: prometheus.SLO{ID: "test1", RuleGroupInterval: ruleGroupIntervalBlank},
 					Rules: prometheus.SLORules{
 						SLIErrorRecRules: []rulefmt.Rule{
 							{
@@ -155,7 +179,7 @@ groups:
 		"Having a multiple SLO alert and recording rules should render correctly.": {
 			slos: []prometheus.StorageSLO{
 				{
-					SLO: prometheus.SLO{ID: "testa", RuleGroupInterval: "3m"},
+					SLO: prometheus.SLO{ID: "testa", RuleGroupInterval: ruleGroupIntervalA},
 					Rules: prometheus.SLORules{
 						SLIErrorRecRules: []rulefmt.Rule{
 							{
@@ -198,7 +222,7 @@ groups:
 					},
 				},
 				{
-					SLO: prometheus.SLO{ID: "testb", RuleGroupInterval: "1h"},
+					SLO: prometheus.SLO{ID: "testb", RuleGroupInterval: ruleGroupIntervalB},
 					Rules: prometheus.SLORules{
 						SLIErrorRecRules: []rulefmt.Rule{
 							{
@@ -293,6 +317,130 @@ groups:
       test-annot: b-1
 `,
 		},
+		"Having a mix of rule group intervals should render correctly.": {
+
+			slos: []prometheus.StorageSLO{
+				{
+					SLO: prometheus.SLO{ID: "testa", SLIErrorRulesInterval: sliErrorRulesInterval, MetadataRulesInterval: metadataRulesInterval, AlertRulesInterval: alertRulesInterval},
+					Rules: prometheus.SLORules{
+						SLIErrorRecRules: []rulefmt.Rule{
+							{
+								Record: "test:record-a1",
+								Expr:   "test-expr-a1",
+								Labels: map[string]string{"test-label": "a-1"},
+							},
+						},
+						MetadataRecRules: []rulefmt.Rule{
+							{
+								Record: "test:record-a3",
+								Expr:   "test-expr-a3",
+								Labels: map[string]string{"test-label": "a-3"},
+							},
+						},
+						AlertRules: []rulefmt.Rule{
+							{
+								Alert:       "testAlertA1",
+								Expr:        "test-expr-a1",
+								Labels:      map[string]string{"test-label": "a-1"},
+								Annotations: map[string]string{"test-annot": "a-1"},
+							},
+						},
+					},
+				},
+			},
+			expYAML: `
+---
+# Code generated by Sloth (dev): https://github.com/slok/sloth.
+# DO NOT EDIT.
+
+groups:
+- name: sloth-slo-sli-recordings-testa
+  interval: 4m
+  rules:
+  - record: test:record-a1
+    expr: test-expr-a1
+    labels:
+      test-label: a-1
+- name: sloth-slo-meta-recordings-testa
+  interval: 5m
+  rules:
+  - record: test:record-a3
+    expr: test-expr-a3
+    labels:
+      test-label: a-3
+- name: sloth-slo-alerts-testa
+  interval: 6m
+  rules:
+  - alert: testAlertA1
+    expr: test-expr-a1
+    labels:
+      test-label: a-1
+    annotations:
+      test-annot: a-1
+`},
+		"Having a mix of rule group intervals and the overarching rule_group interval should render correctly.": {
+
+			slos: []prometheus.StorageSLO{
+				{
+					SLO: prometheus.SLO{ID: "testa", SLIErrorRulesInterval: sliErrorRulesInterval, MetadataRulesInterval: metadataRulesInterval, RuleGroupInterval: ruleGroupInterval},
+					// in this case we use the broad RuleGroupInterval to set a 2m interval for the alert rules
+					// that dont have an explicit one set
+					Rules: prometheus.SLORules{
+						SLIErrorRecRules: []rulefmt.Rule{
+							{
+								Record: "test:record-a1",
+								Expr:   "test-expr-a1",
+								Labels: map[string]string{"test-label": "a-1"},
+							},
+						},
+						MetadataRecRules: []rulefmt.Rule{
+							{
+								Record: "test:record-a3",
+								Expr:   "test-expr-a3",
+								Labels: map[string]string{"test-label": "a-3"},
+							},
+						},
+						AlertRules: []rulefmt.Rule{
+							{
+								Alert:       "testAlertA1",
+								Expr:        "test-expr-a1",
+								Labels:      map[string]string{"test-label": "a-1"},
+								Annotations: map[string]string{"test-annot": "a-1"},
+							},
+						},
+					},
+				},
+			},
+			expYAML: `
+---
+# Code generated by Sloth (dev): https://github.com/slok/sloth.
+# DO NOT EDIT.
+
+groups:
+- name: sloth-slo-sli-recordings-testa
+  interval: 4m
+  rules:
+  - record: test:record-a1
+    expr: test-expr-a1
+    labels:
+      test-label: a-1
+- name: sloth-slo-meta-recordings-testa
+  interval: 5m
+  rules:
+  - record: test:record-a3
+    expr: test-expr-a3
+    labels:
+      test-label: a-3
+- name: sloth-slo-alerts-testa
+  interval: 2m
+  rules:
+  - alert: testAlertA1
+    expr: test-expr-a1
+    labels:
+      test-label: a-1
+    annotations:
+      test-annot: a-1
+`},
 	}
 
 	for name, test := range tests {