Skip to content

Commit 6954b09

Browse files
committed
@todo udpates
1 parent a336e58 commit 6954b09

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

app/Classes/LDAP/Schema/ObjectClass.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ final class ObjectClass extends Base
4343
*
4444
* @param string $line Schema Line
4545
* @param Server $server
46-
* @todo Change $server to $connection, no need to store the server object here
46+
* @todo Deprecate this $server variable? It is only used for isForceMay() determination, and that might be better done elsewhere?
4747
*/
4848
public function __construct(string $line,Server $server)
4949
{

app/Classes/LDAP/Server.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -310,6 +310,7 @@ public function fetch(string $dn,array $attrs=['*','+']): ?Model
310310
* as configured in config.php.
311311
*
312312
* @return boolean True if the specified attribute is configured to be force as a may attribute
313+
* @todo There are 3 isForceMay() functions - we only need one
313314
*/
314315
public function isForceMay($attr_name): bool
315316
{

app/Ldap/Entry.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,6 @@ public function getAttributes(): array
6969

7070
/**
7171
* Determine if the new and old values for a given key are equivalent.
72-
*
73-
* @todo This function barfs on language tags, eg: key = givenname;lang-ja
7472
*/
7573
protected function originalIsEquivalent(string $key): bool
7674
{

0 commit comments

Comments
 (0)