Skip to content

Commit 3cf81f3

Browse files
authored
Merge pull request #2309 from Shaikh-Ubaid/fix_node_compare
CMake: Fix node version compare
2 parents 50ae786 + a3b8e60 commit 3cf81f3

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

integration_tests/CMakeLists.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -286,10 +286,10 @@ macro(RUN_UTIL RUN_FAIL RUN_NAME RUN_FILE_NAME RUN_LABELS RUN_EXTRAFILES RUN_NOM
286286
execute_process(COMMAND "${WASM_EXEC_RUNTIME}" --version
287287
OUTPUT_VARIABLE WASM_EXEC_VERSION
288288
OUTPUT_STRIP_TRAILING_WHITESPACE)
289-
string(COMPARE GREATER_EQUAL "${WASM_EXEC_VERSION}"
290-
"v16.0.0" IS_NODE_ABOVE_16)
291289

292-
if (NOT IS_NODE_ABOVE_16)
290+
string(REGEX REPLACE "v([0-9]+)\\.([0-9]+)\\.([0-9]+)" "\\1" NODE_MAJOR_VERSION "${WASM_EXEC_VERSION}")
291+
292+
if (NODE_MAJOR_VERSION LESS 16)
293293
message(STATUS "${WASM_EXEC_RUNTIME} version: ${WASM_EXEC_VERSION}")
294294
set(WASM_EXEC_FLAGS "--experimental-wasm-bigint")
295295
endif()

0 commit comments

Comments
 (0)