fix(slr): deleting old entries from ipmapping to avoid clogging loadbalancer

Signed-off-by: SkalaNetworks <[email protected]>

Author: SkalaNetworks

pkg/ovs/ovn-nb-load_balancer.go

@@ -535,7 +535,24 @@ func (c *OVNNbClient) LoadBalancerUpdateIPPortMapping(lbName, vipEndpoint string
 		ops, err := c.LoadBalancerOp(
 			lbName,
 			func(lb *ovnnb.LoadBalancer) []model.Mutation {
+				// Delete from the IPPortMappings any outdated mapping
+				mappingToDelete := make(map[string]string)
+				for portIP, portMapVip := range lb.IPPortMappings {
+					if _, ok := ipPortMappings[portIP]; !ok {
+						mappingToDelete[portIP] = portMapVip
+					}
+				}
+
+				if len(mappingToDelete) > 0 {
+					klog.Infof("deleting outdated entry from ipportmapping %v", mappingToDelete)
+				}
+
 				return []model.Mutation{
+					{
+						Field:   &lb.IPPortMappings,
+						Value:   mappingToDelete,
+						Mutator: ovsdb.MutateOperationDelete,
+					},
 					{
 						Field:   &lb.IPPortMappings,
 						Value:   ipPortMappings,