Skip to content

Commit 5a3dc84

Browse files
authored
chore(tests): remove unused logic (#11816)
Signed-off-by: droctothorpe <[email protected]>
1 parent 464ca39 commit 5a3dc84

File tree

2 files changed

+1
-25
lines changed

2 files changed

+1
-25
lines changed

.github/workflows/sdk-execution.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ jobs:
7474
run: |
7575
export KFP_ENDPOINT="http://localhost:8888"
7676
export TIMEOUT_SECONDS=2700
77-
pytest -v -n 5 -rP ./test/sdk-execution-tests/sdk_execution_tests.py
77+
pytest -v -n 5 ./test/sdk-execution-tests/sdk_execution_tests.py
7878
continue-on-error: true
7979

8080
- name: Collect failed logs

test/sdk-execution-tests/sdk_execution_tests.py

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
import dataclasses
1515
import functools
1616
import os
17-
import subprocess
1817
import sys
1918
from typing import Any, Dict, List, Tuple
2019

@@ -146,26 +145,3 @@ def test(test_case: TestCase) -> None:
146145

147146
if __name__ == '__main__':
148147
pytest.main()
149-
150-
print("'df -h' output before minio pvc deletion:")
151-
result = subprocess.run(['df', '-h'],
152-
capture_output=True,
153-
text=True,
154-
check_returncode=True)
155-
print(result.stdout)
156-
157-
try:
158-
print(f'Deleting minio pvc...')
159-
kubernetes.client.CoreV1Api().delete_namespaced_persistent_volume_claim(
160-
name='minio-pvc',
161-
namespace=KFP_NAMESPACE,
162-
)
163-
164-
print("'df -h' output after minio pvc deletion:")
165-
result = subprocess.run(['df', '-h'],
166-
capture_output=True,
167-
text=True,
168-
check_returncode=True)
169-
print(result.stdout)
170-
except kubernetes.client.rest.ApiException as e:
171-
print(f'Failed to delete the minio pvc: {e}', file=sys.stderr)

0 commit comments

Comments
 (0)