remove session_surcharge_metadata from PaymentData and pass in function

Author: hrithikesh026

crates/router/src/core/payments.rs

@@ -214,6 +214,7 @@ where
                     &operation,
                     payment_data,
                     &customer,
+                    None,
                 )
                 .await?
             }
@@ -791,6 +792,7 @@ where
     router_data_res
 }
 
+#[allow(clippy::too_many_arguments)]
 pub async fn call_multiple_connectors_service<F, Op, Req, Ctx>(
     state: &AppState,
     merchant_account: &domain::MerchantAccount,
@@ -799,6 +801,7 @@ pub async fn call_multiple_connectors_service<F, Op, Req, Ctx>(
     _operation: &Op,
     mut payment_data: PaymentData<F>,
     customer: &Option<domain::Customer>,
+    session_surcharge_metadata: Option<SurchargeMetadata>,
 ) -> RouterResult<PaymentData<F>>
 where
     Op: Debug,
@@ -830,8 +833,7 @@ where
             false,
         )
         .await?;
-        payment_data.surcharge_details = payment_data
-            .session_surcharge_details
+        payment_data.surcharge_details = session_surcharge_metadata
             .as_ref()
             .and_then(|surcharge_metadata| {
                 surcharge_metadata.surcharge_results.get(
@@ -1477,7 +1479,6 @@ where
     pub ephemeral_key: Option<ephemeral_key::EphemeralKey>,
     pub redirect_response: Option<api_models::payments::RedirectResponse>,
     pub surcharge_details: Option<SurchargeDetailsResponse>,
-    pub session_surcharge_details: Option<SurchargeMetadata>,
     pub frm_message: Option<FraudCheck>,
     pub payment_link_data: Option<api_models::payments::PaymentLinkResponse>,
 }

crates/router/src/core/payments/operations/payment_approve.rs

@@ -252,7 +252,6 @@ impl<F: Send + Clone, Ctx: PaymentMethodRetrieve>
                 multiple_capture_data: None,
                 redirect_response,
                 surcharge_details: None,
-                session_surcharge_details: None,
                 frm_message: frm_response.ok(),
                 payment_link_data: None,
             },

crates/router/src/core/payments/operations/payment_cancel.rs

@@ -172,7 +172,6 @@ impl<F: Send + Clone, Ctx: PaymentMethodRetrieve>
                 multiple_capture_data: None,
                 redirect_response: None,
                 surcharge_details: None,
-                session_surcharge_details: None,
                 frm_message: None,
                 payment_link_data: None,
             },

crates/router/src/core/payments/operations/payment_capture.rs

@@ -234,7 +234,6 @@ impl<F: Send + Clone, Ctx: PaymentMethodRetrieve>
                 multiple_capture_data,
                 redirect_response: None,
                 surcharge_details: None,
-                session_surcharge_details: None,
                 frm_message: None,
                 payment_link_data: None,
             },

crates/router/src/core/payments/operations/payment_complete_authorize.rs

@@ -247,7 +247,6 @@ impl<F: Send + Clone, Ctx: PaymentMethodRetrieve>
                 multiple_capture_data: None,
                 redirect_response,
                 surcharge_details: None,
-                session_surcharge_details: None,
                 frm_message: None,
                 payment_link_data: None,
             },

crates/router/src/core/payments/operations/payment_confirm.rs

@@ -382,7 +382,6 @@ impl<F: Send + Clone, Ctx: PaymentMethodRetrieve>
                 multiple_capture_data: None,
                 redirect_response: None,
                 surcharge_details,
-                session_surcharge_details: None,
                 frm_message: None,
                 payment_link_data: None,
             },

crates/router/src/core/payments/operations/payment_create.rs

@@ -310,7 +310,6 @@ impl<F: Send + Clone, Ctx: PaymentMethodRetrieve>
                 multiple_capture_data: None,
                 redirect_response: None,
                 surcharge_details: None,
-                session_surcharge_details: None,
                 frm_message: None,
                 payment_link_data,
             },

crates/router/src/core/payments/operations/payment_method_validate.rs

@@ -198,7 +198,6 @@ impl<F: Send + Clone, Ctx: PaymentMethodRetrieve>
                 multiple_capture_data: None,
                 redirect_response: None,
                 surcharge_details: None,
-                session_surcharge_details: None,
                 frm_message: None,
                 payment_link_data: None,
             },

crates/router/src/core/payments/operations/payment_reject.rs

@@ -158,7 +158,6 @@ impl<F: Send + Clone, Ctx: PaymentMethodRetrieve>
                 multiple_capture_data: None,
                 redirect_response: None,
                 surcharge_details: None,
-                session_surcharge_details: None,
                 frm_message: frm_response.ok(),
                 payment_link_data: None,
             },

crates/router/src/core/payments/operations/payment_session.rs

@@ -200,7 +200,6 @@ impl<F: Send + Clone, Ctx: PaymentMethodRetrieve>
                 multiple_capture_data: None,
                 redirect_response: None,
                 surcharge_details: None,
-                session_surcharge_details: None,
                 frm_message: None,
                 payment_link_data: None,
             },