refactor: add validations around login

Author: pixincreate

cypress-tests/cypress/e2e/spec/Routing/00000-PriorityRouting.cy.js

@@ -8,11 +8,29 @@ describe("Priority Based Routing Test", () => {
   let shouldContinue = true;
 
   beforeEach(() => {
-    // Restore the session if it exists
     cy.session("login", () => {
-      cy.userLogin(globalState);
-      cy.terminate2Fa(globalState);
-      cy.userInfo(globalState);
+      // Make sure we have credentials
+      if (!globalState.get("email") || !globalState.get("password")) {
+        throw new Error("Missing login credentials in global state");
+      }
+
+      cy.userLogin(globalState)
+        .then(() => cy.terminate2Fa(globalState))
+        .then(() => cy.userInfo(globalState))
+        .then(() => {
+          // Verify we have all necessary tokens and IDs
+          const requiredKeys = [
+            "userInfoToken",
+            "merchantId",
+            "organizationId",
+            "profileId",
+          ];
+          requiredKeys.forEach((key) => {
+            if (!globalState.get(key)) {
+              throw new Error(`Missing required key after login: ${key}`);
+            }
+          });
+        });
     });
   });
 

cypress-tests/cypress/e2e/spec/Routing/00001-VolumeBasedRouting.cy.js

@@ -7,10 +7,31 @@ let globalState;
 describe("Volume Based Routing Test", () => {
   beforeEach(() => {
     // Restore the session if it exists
-    cy.session("login", () => {
-      cy.userLogin(globalState);
-      cy.terminate2Fa(globalState);
-      cy.userInfo(globalState);
+    beforeEach(() => {
+      cy.session("login", () => {
+        // Make sure we have credentials
+        if (!globalState.get("email") || !globalState.get("password")) {
+          throw new Error("Missing login credentials in global state");
+        }
+
+        cy.userLogin(globalState)
+          .then(() => cy.terminate2Fa(globalState))
+          .then(() => cy.userInfo(globalState))
+          .then(() => {
+            // Verify we have all necessary tokens and IDs
+            const requiredKeys = [
+              "userInfoToken",
+              "merchantId",
+              "organizationId",
+              "profileId",
+            ];
+            requiredKeys.forEach((key) => {
+              if (!globalState.get(key)) {
+                throw new Error(`Missing required key after login: ${key}`);
+              }
+            });
+          });
+      });
     });
   });
 

cypress-tests/cypress/e2e/spec/Routing/00002-RuleBasedRouting.cy.js

@@ -7,10 +7,31 @@ let globalState;
 describe("Rule Based Routing Test", () => {
   beforeEach(() => {
     // Restore the session if it exists
-    cy.session("login", () => {
-      cy.userLogin(globalState);
-      cy.terminate2Fa(globalState);
-      cy.userInfo(globalState);
+    beforeEach(() => {
+      cy.session("login", () => {
+        // Make sure we have credentials
+        if (!globalState.get("email") || !globalState.get("password")) {
+          throw new Error("Missing login credentials in global state");
+        }
+
+        cy.userLogin(globalState)
+          .then(() => cy.terminate2Fa(globalState))
+          .then(() => cy.userInfo(globalState))
+          .then(() => {
+            // Verify we have all necessary tokens and IDs
+            const requiredKeys = [
+              "userInfoToken",
+              "merchantId",
+              "organizationId",
+              "profileId",
+            ];
+            requiredKeys.forEach((key) => {
+              if (!globalState.get(key)) {
+                throw new Error(`Missing required key after login: ${key}`);
+              }
+            });
+          });
+      });
     });
   });
 

cypress-tests/cypress/e2e/spec/Routing/00003-Retries.cy.js

@@ -7,10 +7,31 @@ let globalState;
 describe("Auto Retries & Step Up 3DS", () => {
   beforeEach(() => {
     // Restore the session if it exists
-    cy.session("login", () => {
-      cy.userLogin(globalState);
-      cy.terminate2Fa(globalState);
-      cy.userInfo(globalState);
+    beforeEach(() => {
+      cy.session("login", () => {
+        // Make sure we have credentials
+        if (!globalState.get("email") || !globalState.get("password")) {
+          throw new Error("Missing login credentials in global state");
+        }
+
+        cy.userLogin(globalState)
+          .then(() => cy.terminate2Fa(globalState))
+          .then(() => cy.userInfo(globalState))
+          .then(() => {
+            // Verify we have all necessary tokens and IDs
+            const requiredKeys = [
+              "userInfoToken",
+              "merchantId",
+              "organizationId",
+              "profileId",
+            ];
+            requiredKeys.forEach((key) => {
+              if (!globalState.get(key)) {
+                throw new Error(`Missing required key after login: ${key}`);
+              }
+            });
+          });
+      });
     });
   });
 

cypress-tests/cypress/support/commands.js

@@ -3098,6 +3098,9 @@ Cypress.Commands.add("userLogin", (globalState) => {
           .be.empty;
 
         const totpToken = response.body.token;
+        if (!totpToken) {
+          throw new Error("No token received from login");
+        }
         globalState.set("totpToken", totpToken);
       }
     } else {
@@ -3131,6 +3134,9 @@ Cypress.Commands.add("terminate2Fa", (globalState) => {
           .to.not.be.empty;
 
         const userInfoToken = response.body.token;
+        if (!userInfoToken) {
+          throw new Error("No user info token received");
+        }
         globalState.set("userInfoToken", userInfoToken);
       }
     } else {
@@ -3143,14 +3149,18 @@ Cypress.Commands.add("terminate2Fa", (globalState) => {
 Cypress.Commands.add("userInfo", (globalState) => {
   // Define the necessary variables and constant
   const baseUrl = globalState.get("baseUrl");
-  const apiKey = globalState.get("userInfoToken");
+  const userInfoToken = globalState.get("userInfoToken");
   const url = `${baseUrl}/user`;
 
+  if (!userInfoToken) {
+    throw new Error("No user info token available");
+  }
+
   cy.request({
     method: "GET",
     url: url,
     headers: {
-      Authorization: `Bearer ${apiKey}`,
+      Authorization: `Bearer ${userInfoToken}`,
       "Content-Type": "application/json",
     },
     failOnStatusCode: false,
@@ -3169,7 +3179,7 @@ Cypress.Commands.add("userInfo", (globalState) => {
       globalState.set("organizationId", response.body.org_id);
       globalState.set("profileId", response.body.profile_id);
 
-      globalState.set("userInfoToken", apiKey);
+      globalState.set("userInfoToken", userInfoToken);
     } else {
       throw new Error(
         `User login call failed to fetch user info with status: "${response.status}" and message: "${response.body.error.message}"`