Skip to content

Commit 6081283

Browse files
authored
refactor(authz): Make connector list accessible by operation groups (#6792)
1 parent 71574a8 commit 6081283

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

crates/router/src/routes/admin.rs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -431,7 +431,10 @@ pub async fn connector_retrieve(
431431
&auth::AdminApiAuthWithMerchantIdFromHeader,
432432
&auth::JWTAuthMerchantFromRoute {
433433
merchant_id,
434-
required_permission: Permission::ProfileConnectorRead,
434+
// This should ideally be ProfileConnectorRead, but since this API responds with
435+
// sensitive data, keeping this as ProfileConnectorWrite
436+
// TODO: Convert this to ProfileConnectorRead once data is masked.
437+
required_permission: Permission::ProfileConnectorWrite,
435438
},
436439
req.headers(),
437440
),

crates/router/src/services/authorization/permission_groups.rs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,12 @@ impl PermissionGroupExt for PermissionGroup {
6161

6262
fn accessible_groups(&self) -> Vec<Self> {
6363
match self {
64-
Self::OperationsView => vec![Self::OperationsView],
65-
Self::OperationsManage => vec![Self::OperationsView, Self::OperationsManage],
64+
Self::OperationsView => vec![Self::OperationsView, Self::ConnectorsView],
65+
Self::OperationsManage => vec![
66+
Self::OperationsView,
67+
Self::OperationsManage,
68+
Self::ConnectorsView,
69+
],
6670

6771
Self::ConnectorsView => vec![Self::ConnectorsView],
6872
Self::ConnectorsManage => vec![Self::ConnectorsView, Self::ConnectorsManage],

0 commit comments

Comments
 (0)