refactor: resolve comments

Author: Sakilmostak

crates/diesel_models/src/payment_attempt.rs

@@ -89,7 +89,6 @@ pub struct PaymentAttempt {
     pub capture_before: Option<PrimitiveDateTime>,
     pub card_discovery: Option<storage_enums::CardDiscovery>,
     pub charges: Option<common_types::payments::ConnectorChargeResponseData>,
-    pub setup_future_usage: Option<storage_enums::FutureUsage>,
     pub payment_method_type_v2: storage_enums::PaymentMethod,
     pub connector_payment_id: Option<ConnectorTransactionId>,
     pub payment_method_subtype: Option<storage_enums::PaymentMethodType>,

crates/diesel_models/src/schema_v2.rs

@@ -874,7 +874,6 @@ diesel::table! {
         capture_before -> Nullable<Timestamp>,
         card_discovery -> Nullable<CardDiscovery>,
         charges -> Nullable<Jsonb>,
-        setup_future_usage -> Nullable<FutureUsage>,
         payment_method_type_v2 -> Varchar,
         #[max_length = 128]
         connector_payment_id -> Nullable<Varchar>,

crates/hyperswitch_domain_models/src/payments/payment_attempt.rs

@@ -2194,7 +2194,6 @@ impl behaviour::Conversion for PaymentAttempt {
             network_error_message: error
                 .as_ref()
                 .and_then(|details| details.network_error_message.clone()),
-            setup_future_usage: None,
         })
     }
 

v2_migrations/2025-01-13-081847_drop_v1_columns/up.sql

@@ -91,7 +91,8 @@ ALTER TABLE payment_attempt DROP COLUMN attempt_id,
     DROP COLUMN connector_mandate_detail,
     DROP COLUMN charge_id,
     DROP COLUMN issuer_error_code,
-    DROP COLUMN issuer_error_message;
+    DROP COLUMN issuer_error_message,
+    DROP COLUMN setup_future_usage;
 
 
 ALTER TABLE payment_methods