address comments

Author: hrithikesh026

crates/api_models/src/payments.rs

@@ -2588,7 +2588,7 @@ pub struct ExternalAuthenticationDetailsResponse {
     /// Electronic Commerce Indicator (eci)
     pub electronic_commerce_indicator: Option<String>,
     /// Authentication Status
-    #[schema(value_type = Option<AuthenticationStatus>)]
+    #[schema(value_type = AuthenticationStatus)]
     pub status: enums::AuthenticationStatus,
     /// DS Transaction ID
     pub ds_transaction_id: Option<String>,
@@ -3487,7 +3487,7 @@ pub struct SdkInformation {
     /// Identifies the vendor and version for the 3DS SDK that is integrated in a 3DS Requestor App
     pub sdk_reference_number: String,
     /// Indicates maximum amount of time in minutes
-    pub sdk_max_timeout: i8,
+    pub sdk_max_timeout: u8,
 }
 
 #[derive(Clone, Default, Debug, serde::Serialize, serde::Deserialize, Eq, PartialEq, ToSchema)]

openapi/openapi_spec.json

@@ -8115,6 +8115,9 @@
       },
       "ExternalAuthenticationDetailsResponse": {
         "type": "object",
+        "required": [
+          "status"
+        ],
         "properties": {
           "authentication_flow": {
             "allOf": [
@@ -8130,12 +8133,7 @@
             "nullable": true
           },
           "status": {
-            "allOf": [
-              {
-                "$ref": "#/components/schemas/AuthenticationStatus"
-              }
-            ],
-            "nullable": true
+            "$ref": "#/components/schemas/AuthenticationStatus"
           },
           "ds_transaction_id": {
             "type": "string",
@@ -16208,7 +16206,8 @@
           "sdk_max_timeout": {
             "type": "integer",
             "format": "int32",
-            "description": "Indicates maximum amount of time in minutes"
+            "description": "Indicates maximum amount of time in minutes",
+            "minimum": 0
           }
         }
       },