Skip to content

Commit 4a3f2be

Browse files
author
Vrishab Srivatsa
committed
fix: threeDsMethod logs change
1 parent 1ac46bf commit 4a3f2be

File tree

3 files changed

+8
-30
lines changed

3 files changed

+8
-30
lines changed

src/Payments/CardPayment.res

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -190,8 +190,6 @@ let make = (
190190

191191
let nicknameFieldClassName = conditionsForShowingSaveCardCheckbox ? "pt-2" : "pt-5"
192192

193-
Js.log2("sdvjnsddsjd", (list.mandate_payment, options.terms.card))
194-
195193
<div className="animate-slowShow">
196194
<RenderIf condition={showFields || isBancontact}>
197195
<div

src/ThreeDSMethod.res

Lines changed: 6 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ let make = () => {
1212
LoggerUtils.handleLogging(
1313
~optLogger=Some(logger),
1414
~eventName=THREE_DS_METHOD_RESULT,
15-
~value="Successful Form Submission",
15+
~value="Y",
1616
~paymentMethod="CARD",
1717
(),
1818
)
@@ -59,14 +59,13 @@ let make = () => {
5959

6060
let iframeId = metaDataDict->getString("iframeId", "")
6161

62-
let handleFailureScenarios = (eventName, value, internalMetadata, logType) => {
62+
let handleFailureScenarios = value => {
6363
LoggerUtils.handleLogging(
6464
~optLogger=Some(logger),
65-
~eventName,
65+
~eventName=THREE_DS_METHOD_RESULT,
6666
~value,
67-
~internalMetadata,
6867
~paymentMethod="CARD",
69-
~logType,
68+
~logType=ERROR,
7069
(),
7170
)
7271
metadata->Utils.getDictFromJson->Dict.set("3dsMethodComp", "N"->JSON.Encode.string)
@@ -89,31 +88,16 @@ let make = () => {
8988
input.value = encodeURIComponent(threeDsMethodStr)
9089
form.target = "threeDsInvisibleIframe"
9190
form.appendChild(input)
92-
93-
LoggerUtils.handleLogging(
94-
~optLogger=Some(logger),
95-
~eventName=THREE_DS_METHOD,
96-
~value="Submitting Form",
97-
~paymentMethod="CARD",
98-
(),
99-
)
100-
10191
try {
10292
form.submit()
10393
} catch {
10494
| err => {
10595
let exceptionMessage = err->Utils.formatException->JSON.stringify
106-
handleFailureScenarios(
107-
THREE_DS_METHOD_RESULT,
108-
"Form Submission Failed",
109-
exceptionMessage,
110-
ERROR,
111-
)
96+
handleFailureScenarios(exceptionMessage)
11297
}
11398
}
11499
}
115-
| None =>
116-
handleFailureScenarios(THREE_DS_METHOD, "Unable to Locate threeDsInvisibleDiv", "", INFO)
100+
| None => handleFailureScenarios("Unable to Locate threeDsInvisibleDiv")
117101
}
118102
}
119103
}

src/orca-log-catcher/OrcaLogger.res

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@ type eventName =
1414
| RETRIEVE_CALL
1515
| AUTHENTICATION_CALL_INIT
1616
| AUTHENTICATION_CALL
17-
| THREE_DS_METHOD_CALL_INIT
18-
| THREE_DS_METHOD_CALL
1917
| CONFIRM_CALL_INIT
2018
| CONFIRM_CALL
2119
| SESSIONS_CALL_INIT
@@ -79,8 +77,6 @@ let eventNameToStrMapper = eventName => {
7977
| RETRIEVE_CALL => "RETRIEVE_CALL"
8078
| AUTHENTICATION_CALL_INIT => "AUTHENTICATION_CALL_INIT"
8179
| AUTHENTICATION_CALL => "AUTHENTICATION_CALL"
82-
| THREE_DS_METHOD_CALL_INIT => "THREE_DS_METHOD_CALL_INIT"
83-
| THREE_DS_METHOD_CALL => "THREE_DS_METHOD_CALL"
8480
| CONFIRM_CALL_INIT => "CONFIRM_CALL_INIT"
8581
| CONFIRM_CALL => "CONFIRM_CALL"
8682
| SESSIONS_CALL_INIT => "SESSIONS_CALL_INIT"
@@ -499,7 +495,7 @@ let make = (
499495
PAYMENT_ATTEMPT,
500496
CONFIRM_CALL,
501497
AUTHENTICATION_CALL,
502-
THREE_DS_METHOD_CALL,
498+
THREE_DS_METHOD_RESULT,
503499
SDK_CRASH,
504500
REDIRECTING_USER,
505501
DISPLAY_BANK_TRANSFER_INFO_PAGE,
@@ -508,6 +504,7 @@ let make = (
508504
LOADER_CHANGED,
509505
SESSIONS_CALL,
510506
RETRIEVE_CALL,
507+
DISPLAY_THREE_DS_SDK,
511508
]
512509
arrayOfLogs
513510
->Array.find(log => {
@@ -542,7 +539,6 @@ let make = (
542539
}
543540
}
544541
| AUTHENTICATION_CALL
545-
| THREE_DS_METHOD_CALL
546542
| RETRIEVE_CALL
547543
| CONFIRM_CALL
548544
| SESSIONS_CALL

0 commit comments

Comments
 (0)