Add a comment for a bug I'm not sure is worth fixing

jhasse · jhasse · commit 63e007d7229b · 2025-06-26T18:50:31.000+02:00
diff --git a/src/jngl/SoundFile.cpp b/src/jngl/SoundFile.cpp
@@ -314,7 +314,8 @@ Finally pauseAudio() {
 		audio->increasePauseDeviceCount();
 		return Finally([audio]() { audio->decreasePauseDeviceCount(); });
 	}
-	return Finally(nullptr);
+	return Finally(nullptr); // FIXME: This is a bug if the Finally lives so long that the Audio
+	                         // object is created in time
 }
 
 Audio& GetAudio() {

Original file line number	Diff line number	Diff line change
`@@ -314,7 +314,8 @@ Finally pauseAudio() {`
`314`	`314`	`audio->increasePauseDeviceCount();`
`315`	`315`	`return Finally([audio]() { audio->decreasePauseDeviceCount(); });`
`316`	`316`	`}`
`317`		`- return Finally(nullptr);`
	`317`	`+ return Finally(nullptr); // FIXME: This is a bug if the Finally lives so long that the Audio`
	`318`	`+ // object is created in time`
`318`	`319`	`}`
`319`	`320`
`320`	`321`	`Audio& GetAudio() {`