Skip to content

Commit 197a30a

Browse files
fix: resolve todo by pass cause to the Error constructor (#15755)
1 parent a2dd2d0 commit 197a30a

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

packages/jest-message-util/src/__tests__/__snapshots__/messages.test.ts.snap

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ exports[`should return the error cause if there is one 1`] = `
162162
Cause:
163163
Cause Error
164164
165-
<dim>at Object.<anonymous> (</intensity>packages/jest-message-util/src/__tests__/messages.test.ts<dim>:567:17)</intensity>
165+
<dim>at Object.<anonymous> (</intensity>packages/jest-message-util/src/__tests__/messages.test.ts<dim>:565:12)</intensity>
166166
167167
"
168168
`;
@@ -172,16 +172,16 @@ exports[`should return the inner errors of an AggregateError 1`] = `
172172
173173
AggregateError:
174174
175-
<dim>at Object.<anonymous> (</intensity>packages/jest-message-util/src/__tests__/messages.test.ts<dim>:583:20)</intensity>
175+
<dim>at Object.<anonymous> (</intensity>packages/jest-message-util/src/__tests__/messages.test.ts<dim>:582:20)</intensity>
176176
177177
Errors contained in AggregateError:
178178
Err 1
179179
180-
<dim>at Object.<anonymous> (</intensity>packages/jest-message-util/src/__tests__/messages.test.ts<dim>:583:40)</intensity>
180+
<dim>at Object.<anonymous> (</intensity>packages/jest-message-util/src/__tests__/messages.test.ts<dim>:582:40)</intensity>
181181
182182
Err 2
183183
184-
<dim>at Object.<anonymous> (</intensity>packages/jest-message-util/src/__tests__/messages.test.ts<dim>:583:60)</intensity>
184+
<dim>at Object.<anonymous> (</intensity>packages/jest-message-util/src/__tests__/messages.test.ts<dim>:582:60)</intensity>
185185
186186
"
187187
`;

packages/jest-message-util/src/__tests__/messages.test.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -561,10 +561,9 @@ it('getTopFrame should return a path for mjs files', () => {
561561
});
562562

563563
it('should return the error cause if there is one', () => {
564-
const error = new Error('Test exception');
565-
// TODO pass `cause` to the `Error` constructor when lowest supported Node version is 16.9.0 and above
566-
// See https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V16.md#error-cause
567-
error.cause = new Error('Cause Error');
564+
const error = new Error('Test exception', {
565+
cause: new Error('Cause Error'),
566+
});
568567
const message = formatExecError(
569568
error,
570569
{

0 commit comments

Comments
 (0)