fix(r/trigger): validate threshold when baseline_details in use (#708)

Adds validation support for baseline triggers so that basic constraints
can be caught prior to the `apply` phase.

- Closes #704

Author: jharley

internal/provider/trigger_resource.go

@@ -661,6 +661,39 @@ func (r *triggerResource) ValidateConfig(ctx context.Context, req resource.Valid
 			)
 		}
 	}
+
+	// ensure baseline_details conditions are met
+	if !data.BaselineDetails.IsNull() && !data.BaselineDetails.IsUnknown() {
+		threshold := expandTriggerThreshold(ctx, data.Threshold, &resp.Diagnostics)
+		if resp.Diagnostics.HasError() {
+			return
+		}
+
+		switch threshold.Op {
+		case client.TriggerThresholdOpGreaterThanOrEqual:
+			if threshold.Value < 0 {
+				resp.Diagnostics.AddAttributeError(
+					path.Root("threshold").AtName("value"),
+					"Trigger validation error",
+					"Triggers with baseline_details and a threshold operator of '>=' must have a value greater than or equal to 0.",
+				)
+			}
+		case client.TriggerThresholdOpLessThanOrEqual:
+			if threshold.Value > 0 {
+				resp.Diagnostics.AddAttributeError(
+					path.Root("threshold").AtName("value"),
+					"Trigger validation error",
+					"Triggers with baseline_details and a threshold operator of '<=' must have a value less than or equal to 0.",
+				)
+			}
+		default:
+			resp.Diagnostics.AddAttributeError(
+				path.Root("threshold").AtName("op"),
+				"Trigger validation error",
+				"Triggers with baseline_details must use a threshold operator of '>=' or '<='.",
+			)
+		}
+	}
 }
 
 func expandTriggerThreshold(

internal/provider/trigger_resource_test.go

@@ -192,14 +192,151 @@ func TestAcc_TriggerResource(t *testing.T) {
 		})
 	})
 
-	t.Run("trigger with partial baseline_details errors", func(t *testing.T) {
+	t.Run("trigger with baseline_details validates", func(t *testing.T) {
 		resource.Test(t, resource.TestCase{
 			PreCheck:                 testAccPreCheck(t),
 			ProtoV5ProviderFactories: testAccProtoV5MuxServerFactory,
 			Steps: []resource.TestStep{
 				{
 					Config:      testAccConfigBasicTriggerWithBaselineDetailsTest(dataset, name, true, true),
 					ExpectError: regexp.MustCompile(`The argument "offset_minutes" is required, but no definition was found.`),
+					PlanOnly:    true,
+				},
+				{
+					Config: `
+data "honeycombio_query_specification" "test" {
+  calculation {
+    op     = "AVG"
+    column = "duration_ms"
+  }
+
+  time_range = 1200
+}
+
+resource "honeycombio_trigger" "test" {
+  name    = "Test trigger with baseline_details errors"
+  dataset = "foobar"
+
+  description = "My nice description"
+
+  query_json = data.honeycombio_query_specification.test.json
+
+  threshold {
+    op    = ">"
+    value = 100
+  }
+
+  baseline_details {
+    type            = "percentage"
+    offset_minutes  = 1440
+  }
+
+  frequency = 1200
+}`,
+					ExpectError: regexp.MustCompile(`must use a threshold operator of '>=' or '<='`),
+					PlanOnly:    true,
+				},
+				{
+					Config: `
+data "honeycombio_query_specification" "test" {
+  calculation {
+    op     = "AVG"
+    column = "duration_ms"
+  }
+
+  time_range = 1200
+}
+
+resource "honeycombio_trigger" "test" {
+  name    = "Test trigger with baseline_details errors"
+  dataset = "foobar"
+
+  description = "My nice description"
+
+  query_json = data.honeycombio_query_specification.test.json
+
+  threshold {
+    op    = ">="
+    value = -838
+  }
+
+  baseline_details {
+    type            = "percentage"
+    offset_minutes  = 1440
+  }
+
+  frequency = 1200
+}`,
+					ExpectError: regexp.MustCompile(`value greater than or equal to 0`),
+					PlanOnly:    true,
+				},
+				{
+					Config: `
+data "honeycombio_query_specification" "test" {
+  calculation {
+    op     = "AVG"
+    column = "duration_ms"
+  }
+
+  time_range = 1200
+}
+
+resource "honeycombio_trigger" "test" {
+  name    = "Test trigger with baseline_details errors"
+  dataset = "foobar"
+
+  description = "My nice description"
+
+  query_json = data.honeycombio_query_specification.test.json
+
+  threshold {
+    op    = "<"
+    value = 100
+  }
+
+  baseline_details {
+    type            = "percentage"
+    offset_minutes  = 1440
+  }
+
+  frequency = 1200
+}`,
+					ExpectError: regexp.MustCompile(`must use a threshold operator of '>=' or '<='`),
+					PlanOnly:    true,
+				},
+				{
+					Config: `
+data "honeycombio_query_specification" "test" {
+  calculation {
+    op     = "AVG"
+    column = "duration_ms"
+  }
+
+  time_range = 1200
+}
+
+resource "honeycombio_trigger" "test" {
+  name    = "Test trigger with baseline_details errors"
+  dataset = "foobar"
+
+  description = "My nice description"
+
+  query_json = data.honeycombio_query_specification.test.json
+
+  threshold {
+    op    = "<="
+    value = 100
+  }
+
+  baseline_details {
+    type            = "percentage"
+    offset_minutes  = 1440
+  }
+
+  frequency = 1200
+}`,
+					ExpectError: regexp.MustCompile(`value less than or equal to 0`),
+					PlanOnly:    true,
 				},
 			},
 		})