feat:[CI-13780]: Fixed lint issues (#379)

* feat:[CI-13780]: Fixed lint issues

Author: chhawchharia

engine/pids/pidfile.go

@@ -12,6 +12,11 @@ import (
 	"time"
 )
 
+const (
+	// filePermission defines the permission for creating/writing PID files
+	filePermission = 0644
+)
+
 // ReadPIDsFromFile reads process IDs (PIDs) from a file at the specified path.
 // The file should contain PIDs as comma-separated values.
 // It returns a slice of integers representing the PIDs.
@@ -109,7 +114,7 @@ func AppendPIDToFile(pid int, path string) error {
 	}
 
 	// Open file for appending, create if it doesn't exist
-	file, err := os.OpenFile(path, os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0644)
+	file, err := os.OpenFile(path, os.O_APPEND|os.O_CREATE|os.O_WRONLY, filePermission)
 	if err != nil {
 		return fmt.Errorf("failed to open file %s: %w", path, err)
 	}
@@ -119,9 +124,9 @@ func AppendPIDToFile(pid int, path string) error {
 	var content string
 	if fileExists {
 		// If file exists, check if it's empty or needs a comma separator
-		fileInfo, err := file.Stat()
-		if err != nil {
-			return fmt.Errorf("failed to get file info: %w", err)
+		fileInfo, statErr := file.Stat()
+		if statErr != nil {
+			return fmt.Errorf("failed to get file info: %w", statErr)
 		}
 
 		if fileInfo.Size() > 0 {
@@ -212,13 +217,13 @@ func killProcessWithGracePeriod(pid int, timeout time.Duration) error {
 	// Wait for the process to exit or timeout to expire
 	done := make(chan error)
 	go func() {
-		_, err := process.Wait()
-		done <- err
+		_, waitErr := process.Wait()
+		done <- waitErr
 	}()
 	select {
-	case err := <-done:
-		if err != nil {
-			return err
+	case waitErr := <-done:
+		if waitErr != nil {
+			return waitErr
 		}
 		return nil
 	case <-time.After(timeout):

engine/spec/spec.go

@@ -21,7 +21,7 @@ type (
 		EnableDockerSetup  *bool             `json:"mount_docker_socket"`
 		TTY                bool              `json:"tty,omitempty" default:"false"`
 		MtlsConfig         MtlsConfig        `json:"mtls_config,omitempty"`
-		ProcessIdsFilePath string            `json:"process_ids_file_path,omitempty"` // Path to the file where process IDs are stored. Process IDs are used to track running processes launched by run step on host.
+		ProcessIdsFilePath string            `json:"process_ids_file_path,omitempty"` // Path to the file where process IDs are stored. Process IDs are used to track running processes launched by run step on host. //nolint:lll
 	}
 
 	// Step defines a pipeline step.

logstream/replacer.go

@@ -195,7 +195,7 @@ func NewReplacer(w Writer, secrets []string) Writer {
 
 // NewReplacerWithEnvs returns a replacer that wraps io.Writer w with environment variable support.
 // If CI_ENABLE_EXTRA_CHARACTERS_SECRETS_MASKING is set to "true" in envs, uses advanced variant creation.
-func NewReplacerWithEnvs(w Writer, secrets []string, envs map[string]string) Writer {
+func NewReplacerWithEnvs(w Writer, secrets []string, envs map[string]string) Writer { //nolint:gocyclo
 	// Check if advanced secret masking is enabled
 	useAdvancedMasking := false
 	if envs != nil {

pipeline/runtime/runtestsV2.go

@@ -280,7 +280,7 @@ func getTestsSelection(ctx context.Context, fs filesystem.FileSystem, stepID, wo
 }
 
 func getTestsSelectionWithTiModeEnabled(ctx context.Context, fs filesystem.FileSystem, stepID, workspace string, log *logrus.Logger,
-	isManual bool, tiConfig *tiCfg.Cfg, envs map[string]string, runV2Config *api.RunTestsV2Config, testGlobs []string) (types.SelectTestsResp, bool) {
+	isManual bool, tiConfig *tiCfg.Cfg, envs map[string]string, runV2Config *api.RunTestsV2Config, testGlobs []string) (types.SelectTestsResp, bool) { //nolint:unparam
 	selection := types.SelectTestsResp{}
 	// Question : Here i can see feature state is being defined in Runtest but here we don't have runOnlySelected tests so should we always defined as optimized state
 	var files []types.File