fix: [PIPE-28910]: Fix for local runner on Windows - Convert pipelineConfig volume host paths to Windows format (#389)

* 60739a Add UT

* 188094 Make local runner work on Windows

Author: vcalasansh

engine/engine.go

@@ -235,9 +235,20 @@ func runHelper(cfg *spec.PipelineConfig, step *spec.Step) error {
 		return err
 	}
 
+	// If we are running on Windows, convert
+	// the volume paths to windows paths
 	for _, vol := range step.Volumes {
 		vol.Path = pathConverter(vol.Path)
 	}
+
+	for _, vol := range cfg.Volumes {
+		if vol == nil || vol.HostPath == nil {
+			continue
+		}
+		path := vol.HostPath.Path
+		vol.HostPath.Path = pathConverter(path)
+	}
+
 	return nil
 }
 

engine/engine_test.go

@@ -2,10 +2,12 @@ package engine
 
 import (
 	"bytes"
+	"runtime"
 	"strings"
 	"testing"
 
 	"github.com/harness/lite-engine/engine/spec"
+	"github.com/stretchr/testify/assert"
 )
 
 func TestRun(t *testing.T) {
@@ -55,3 +57,43 @@ func TestRun(t *testing.T) {
 		})
 	}
 }
+
+func TestRunHelper(t *testing.T) {
+	cfg := &spec.PipelineConfig{
+		Envs: map[string]string{
+			"GLOBAL_KEY": "global_value",
+		},
+		Volumes: []*spec.Volume{
+			{
+				HostPath: &spec.VolumeHostPath{Path: "/some/path"},
+			},
+		},
+	}
+
+	step := &spec.Step{
+		Envs: map[string]string{
+			"STEP_KEY": "step_value",
+		},
+		WorkingDir: "/work/dir",
+		Volumes: []*spec.VolumeMount{
+			{Name: "myMount", Path: "/mount/path"},
+		},
+		Files: []*spec.File{},
+	}
+
+	// Act
+	err := runHelper(cfg, step)
+
+	// Assert
+	assert.NoError(t, err)
+	// Env vars should be merged
+	assert.Equal(t, "global_value", step.Envs["GLOBAL_KEY"])
+	assert.Equal(t, "step_value", step.Envs["STEP_KEY"])
+	if runtime.GOOS == "windows" {
+		assert.Equal(t, "c:\\some\\path", cfg.Volumes[0].HostPath.Path)
+		assert.Equal(t, "c:\\mount\\path", step.Volumes[0].Path)
+	} else {
+		assert.Equal(t, "/some/path", cfg.Volumes[0].HostPath.Path)
+		assert.Equal(t, "/mount/path", step.Volumes[0].Path)
+	}
+}