Remove missing_series_evals_to_resolve

Author: alexander-akhmetov

docs/resources/rule_group.md

@@ -144,7 +144,6 @@ Optional:
 - `is_paused` (Boolean) Sets whether the alert should be paused or not. Defaults to `false`.
 - `keep_firing_for` (String) The amount of time for which the rule will considered to be Recovering after initially Firing. Before this time has elapsed, the rule will continue to fire once it's been triggered.
 - `labels` (Map of String) Key-value pairs to attach to the alert rule that can be used in matching, grouping, and routing. Defaults to `map[]`.
-- `missing_series_evals_to_resolve` (Number) The number of missing series evaluations that must occur before the rule is considered to be resolved.
 - `no_data_state` (String) Describes what state to enter when the rule's query returns No Data. Options are OK, NoData, KeepLast, and Alerting. Defaults to NoData if not set.
 - `notification_settings` (Block List, Max: 1) Notification settings for the rule. If specified, it overrides the notification policies. Available since Grafana 10.4, requires feature flag 'alertingSimplifiedRouting' to be enabled. (see [below for nested schema](#nestedblock--rule--notification_settings))
 - `record` (Block List, Max: 1) Settings for a recording rule. Available since Grafana 11.2, requires feature flag 'grafanaManagedRecordingRules' to be enabled. (see [below for nested schema](#nestedblock--rule--record))

internal/resources/grafana/resource_alerting_rule_group.go

@@ -15,7 +15,6 @@ import (
 	goapi "github.com/grafana/grafana-openapi-client-go/client"
 	"github.com/grafana/grafana-openapi-client-go/client/provisioning"
 	"github.com/grafana/grafana-openapi-client-go/models"
-	"github.com/hashicorp/go-cty/cty"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/retry"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
@@ -116,17 +115,6 @@ This resource requires Grafana 9.1.0 or later.
 								return oldDuration == newDuration
 							},
 						},
-						"missing_series_evals_to_resolve": {
-							Type:        schema.TypeInt,
-							Optional:    true,
-							Description: "The number of missing series evaluations that must occur before the rule is considered to be resolved.",
-							ValidateDiagFunc: func(i any, path cty.Path) (diags diag.Diagnostics) {
-								if i != nil && i.(int) < 1 {
-									return diag.Errorf("missing_series_evals_to_resolve must be greater than or equal to 1")
-								}
-								return nil
-							},
-						},
 						"no_data_state": {
 							Type:        schema.TypeString,
 							Optional:    true,
@@ -546,10 +534,6 @@ func packAlertRule(r *models.ProvisionedAlertRule) (interface{}, error) {
 		json["keep_firing_for"] = r.KeepFiringFor.String()
 	}
 
-	if r.MissingSeriesEvalsToResolve >= 1 {
-		json["missing_series_evals_to_resolve"] = r.MissingSeriesEvalsToResolve
-	}
-
 	return json, nil
 }
 
@@ -583,14 +567,6 @@ func unpackAlertRule(raw interface{}, groupName string, folderUID string, orgID
 		return nil, err
 	}
 
-	var missingSeriesEvalsToResolve int64
-	if val, ok := json["missing_series_evals_to_resolve"]; ok && val != nil {
-		intVal := val.(int)
-		if intVal >= 1 {
-			missingSeriesEvalsToResolve = int64(intVal)
-		}
-	}
-
 	// Check for conflicting fields before unpacking the rest of the rule.
 	// This is a workaround due to the lack of support for ConflictsWith in Lists in the SDK.
 	errState := json["exec_err_state"].(string)
@@ -606,9 +582,6 @@ func unpackAlertRule(raw interface{}, groupName string, folderUID string, orgID
 		if keepFiringForDuration != 0 {
 			return nil, fmt.Errorf(incompatFieldMsgFmt, "keep_firing_for")
 		}
-		if missingSeriesEvalsToResolve != 0 {
-			return nil, fmt.Errorf(incompatFieldMsgFmt, "missing_series_evals_to_resolve")
-		}
 		if noDataState != "" {
 			return nil, fmt.Errorf(incompatFieldMsgFmt, "no_data_state")
 		}
@@ -634,23 +607,22 @@ func unpackAlertRule(raw interface{}, groupName string, folderUID string, orgID
 	}
 
 	rule := models.ProvisionedAlertRule{
-		UID:                         json["uid"].(string),
-		Title:                       common.Ref(json["name"].(string)),
-		FolderUID:                   common.Ref(folderUID),
-		RuleGroup:                   common.Ref(groupName),
-		OrgID:                       common.Ref(orgID),
-		ExecErrState:                common.Ref(errState),
-		NoDataState:                 common.Ref(noDataState),
-		For:                         common.Ref(strfmt.Duration(forDuration)),
-		KeepFiringFor:               strfmt.Duration(keepFiringForDuration),
-		Data:                        data,
-		Condition:                   common.Ref(condition),
-		Labels:                      unpackMap(json["labels"]),
-		Annotations:                 unpackMap(json["annotations"]),
-		IsPaused:                    json["is_paused"].(bool),
-		NotificationSettings:        ns,
-		Record:                      unpackRecord(json["record"]),
-		MissingSeriesEvalsToResolve: missingSeriesEvalsToResolve,
+		UID:                  json["uid"].(string),
+		Title:                common.Ref(json["name"].(string)),
+		FolderUID:            common.Ref(folderUID),
+		RuleGroup:            common.Ref(groupName),
+		OrgID:                common.Ref(orgID),
+		ExecErrState:         common.Ref(errState),
+		NoDataState:          common.Ref(noDataState),
+		For:                  common.Ref(strfmt.Duration(forDuration)),
+		KeepFiringFor:        strfmt.Duration(keepFiringForDuration),
+		Data:                 data,
+		Condition:            common.Ref(condition),
+		Labels:               unpackMap(json["labels"]),
+		Annotations:          unpackMap(json["annotations"]),
+		IsPaused:             json["is_paused"].(bool),
+		NotificationSettings: ns,
+		Record:               unpackRecord(json["record"]),
 	}
 
 	return &rule, nil