Skip to content

Commit 629990d

Browse files
authored
Use status code constant (#864)
<!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. For a timely review/response, please avoid force-pushing additional commits if your PR already received reviews or comments. Before submitting a Pull Request, please ensure that you have: - 📖 Read the Contributing guide: https://github.com/gorilla/.github/blob/main/CONTRIBUTING.md - 📖 Read the Code of Conduct: https://github.com/gorilla/.github/blob/main/CODE_OF_CONDUCT.md - Provide tests for your changes. - Use descriptive commit messages. - Comment your code where appropriate. - Squash your commits - Update any related documentation. - Add gorilla/pull-request-reviewers as a Reviewer --> ## What type of PR is this? (check all applicable) - [x] Refactor - [ ] Feature - [ ] Bug Fix - [ ] Optimization - [ ] Documentation Update - [ ] Go Version Update - [ ] Dependency Update ## Description ## Related Tickets & Documents <!-- For pull requests that relate or close an issue, please include them below. We like to follow [Github's guidance on linking issues to pull requests](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue). For example having the text: "closes #1234" would connect the current pull request to issue 1234. And when we merge the pull request, Github will automatically close the issue. --> - Related Issue # - Closes # ## Added/updated tests? - [ ] Yes - [x] No - [ ] I need help with writing tests ## Run verifications and test - [ ] `make verify` is passing - [ ] `make test` is passing
1 parent b6a0d77 commit 629990d

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

client.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -399,7 +399,7 @@ func (d *Dialer) DialContext(ctx context.Context, urlStr string, requestHeader h
399399
}
400400
}
401401

402-
if resp.StatusCode != 101 ||
402+
if resp.StatusCode != http.StatusSwitchingProtocols ||
403403
!tokenListContainsValue(resp.Header, "Upgrade", "websocket") ||
404404
!tokenListContainsValue(resp.Header, "Connection", "upgrade") ||
405405
resp.Header.Get("Sec-Websocket-Accept") != computeAcceptKey(challengeKey) {

proxy.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ func (hpd *httpProxyDialer) Dial(network string, addr string) (net.Conn, error)
7575
return nil, err
7676
}
7777

78-
if resp.StatusCode != 200 {
78+
if resp.StatusCode != http.StatusOK {
7979
if err := conn.Close(); err != nil {
8080
log.Printf("httpProxyDialer: failed to close connection: %v", err)
8181
}

0 commit comments

Comments
 (0)