Skip to content

Commit e75feff

Browse files
author
Franklin Harding
committed
Don't use subtests for MiddlewareAdd
1 parent 2d83221 commit e75feff

File tree

1 file changed

+18
-8
lines changed

1 file changed

+18
-8
lines changed

middleware_test.go

Lines changed: 18 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,24 @@ func TestMiddlewareAdd(t *testing.T) {
2525
router := NewRouter()
2626
router.HandleFunc("/", dummyHandler).Methods("GET")
2727

28-
for i := 0; i < 3; i++ {
29-
t.Run(fmt.Sprintf("adds %d middlewares", i+1), func(t *testing.T) {
30-
mw := &testMiddleware{}
31-
router.useInterface(mw)
32-
if len(router.middlewares) != i+1 || router.middlewares[i] != mw {
33-
t.Fatalf("Middleware %d was not added correctly", i+1)
34-
}
35-
})
28+
mw := &testMiddleware{}
29+
30+
router.useInterface(mw)
31+
if len(router.middlewares) != 1 || router.middlewares[0] != mw {
32+
t.Fatal("Middleware interface was not added correctly")
33+
}
34+
35+
router.Use(mw.Middleware)
36+
if len(router.middlewares) != 2 {
37+
t.Fatal("Middleware method was not added correctly")
38+
}
39+
40+
banalMw := func(handler http.Handler) http.Handler {
41+
return handler
42+
}
43+
router.Use(banalMw)
44+
if len(router.middlewares) != 3 {
45+
t.Fatal("Middleware function was not added correctly")
3646
}
3747
}
3848

0 commit comments

Comments
 (0)