Skip to content

Commit 4c4063f

Browse files
authored
chore: call non-hermetic functions since we're installing node_modules directly from the library (#1870)
* chore: call non-hermetic functions since we're installing node_modules directly from the library
1 parent ee41a29 commit 4c4063f

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

synthtool/languages/node.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -213,6 +213,8 @@ def fix(hide_output=False):
213213
shell.run(["npm", "run", "fix"], hide_output=hide_output)
214214

215215

216+
# TODO: delete these functions if it turns out we no longer
217+
# need them to be hermetic.
216218
def fix_hermetic(hide_output=False):
217219
"""
218220
Fixes the formatting in the current Node.js library. It assumes that gts
@@ -241,6 +243,8 @@ def compile_protos(hide_output=False):
241243
shell.run(["npx", "compileProtos", "src"], hide_output=hide_output)
242244

243245

246+
# TODO: delete these functions if it turns out we no longer
247+
# need them to be hermetic.
244248
def compile_protos_hermetic(hide_output=False):
245249
"""
246250
Compiles protos into .json, .js, and .d.ts files using
@@ -265,8 +269,8 @@ def postprocess_gapic_library(hide_output=False):
265269

266270
def postprocess_gapic_library_hermetic(hide_output=False):
267271
logger.debug("Post-processing GAPIC library...")
268-
fix_hermetic(hide_output=hide_output)
269-
compile_protos_hermetic(hide_output=hide_output)
272+
fix(hide_output=hide_output)
273+
compile_protos(hide_output=hide_output)
270274
logger.debug("Post-processing completed")
271275

272276

0 commit comments

Comments
 (0)