fix linter

Author: efectn

client/request.go

@@ -729,9 +729,9 @@ type QueryParam struct {
 }
 
 // Keys method returns all keys in the query params.
-func (f *QueryParam) Keys() []string {
-	keys := make([]string, f.Len())
-	f.VisitAll(func(key, value []byte) {
+func (p *QueryParam) Keys() []string {
+	keys := make([]string, 0, p.Len())
+	p.VisitAll(func(key, _ []byte) {
 		keys = append(keys, utils.UnsafeString(key))
 	})
 
@@ -870,8 +870,8 @@ type FormData struct {
 
 // Keys method returns all keys in the form data.
 func (f *FormData) Keys() []string {
-	keys := make([]string, f.Len())
-	f.VisitAll(func(key, value []byte) {
+	keys := make([]string, 0, f.Len())
+	f.VisitAll(func(key, _ []byte) {
 		keys = append(keys, utils.UnsafeString(key))
 	})
 

client/request_test.go

@@ -187,7 +187,9 @@ func Benchmark_Request_Headers(b *testing.B) {
 	b.ReportAllocs()
 
 	for i := 0; i < b.N; i++ {
-		for range req.Headers() {
+		for k, v := range req.Headers() {
+			_ = k
+			_ = v
 		}
 	}
 }
@@ -346,7 +348,9 @@ func Benchmark_Request_Params(b *testing.B) {
 	b.ReportAllocs()
 
 	for i := 0; i < b.N; i++ {
-		for range req.Params() {
+		for k, v := range req.Params() {
+			_ = k
+			_ = v
 		}
 	}
 }
@@ -461,7 +465,9 @@ func Benchmark_Request_Cookies(b *testing.B) {
 	b.ReportAllocs()
 
 	for i := 0; i < b.N; i++ {
-		for range req.Cookies() {
+		for k, v := range req.Cookies() {
+			_ = k
+			_ = v
 		}
 	}
 }
@@ -571,7 +577,9 @@ func Benchmark_Request_PathParams(b *testing.B) {
 	b.ReportAllocs()
 
 	for i := 0; i < b.N; i++ {
-		for range req.PathParams() {
+		for k, v := range req.PathParams() {
+			_ = k
+			_ = v
 		}
 	}
 }
@@ -1379,7 +1387,9 @@ func Benchmark_Request_FormDatas(b *testing.B) {
 	b.ReportAllocs()
 
 	for i := 0; i < b.N; i++ {
-		for range req.FormDatas() {
+		for k, v := range req.FormDatas() {
+			_ = k
+			_ = v
 		}
 	}
 }

client/response_test.go

@@ -4,7 +4,6 @@ import (
 	"bytes"
 	"crypto/tls"
 	"encoding/xml"
-	"fmt"
 	"io"
 	"net"
 	"os"
@@ -224,11 +223,7 @@ func Test_Response_Headers(t *testing.T) {
 
 	headers := make(map[string][]string)
 	for k, v := range resp.Headers() {
-		headers[k] = make([]string, 0)
-		for _, value := range v {
-			fmt.Print(string(value))
-			headers[k] = append(headers[k], string(value))
-		}
+		headers[k] = append(headers[k], v...)
 	}
 
 	require.Contains(t, headers["Foo"], "bar")
@@ -270,7 +265,9 @@ func Benchmark_Headers(b *testing.B) {
 			SetClient(client).
 			Get("http://example.com")
 
-		for range resp.Headers() {
+		for k, v := range resp.Headers() {
+			_ = k
+			_ = v
 		}
 
 		resp.Close()