complete some reviews

Author: efectn

error.go

@@ -12,6 +12,11 @@ var (
 	ErrGracefulTimeout = stdErrors.New("shutdown: graceful timeout has been reached, exiting")
 )
 
+// Fiber redirection errors
+var (
+	ErrRedirectBackNoFallback = NewError(StatusInternalServerError, "Referer not found, you have to enter fallback URL for redirection.")
+)
+
 // Range errors
 var (
 	ErrRangeMalformed     = stdErrors.New("range: malformed range header string")

helpers.go

@@ -675,3 +675,6 @@ const (
 	ConstraintDatetime        = "datetime"
 	ConstraintRegex           = "regex"
 )
+
+// Cookie name to send flash messages when to use redirection.
+const FlashCookieName = "fiber_flash"

redirect.go

@@ -184,12 +184,19 @@ func (r *Redirect) Route(name string, config ...RedirectConfig) error {
 }
 
 // Redirect back to the URL to referer.
-// TODO: Should fallback be optional?
-func (r *Redirect) Back(fallback string) error {
+func (r *Redirect) Back(fallback ...string) error {
 	location := r.c.Get(HeaderReferer)
 	if location == "" {
-		location = fallback
+		// Check fallback URL
+		if len(fallback) == 0 {
+			err := ErrRedirectBackNoFallback
+			r.c.Status(err.Code)
+
+			return err
+		}
+		location = fallback[0]
 	}
+
 	return r.To(location)
 }
 

redirect_test.go

@@ -134,6 +134,10 @@ func Test_Redirect_Back(t *testing.T) {
 	c.Redirect().Back("/")
 	require.Equal(t, 302, c.Response().StatusCode())
 	require.Equal(t, "/", string(c.Response().Header.Peek(HeaderLocation)))
+
+	err := c.Redirect().Back()
+	require.Equal(t, 500, c.Response().StatusCode())
+	require.ErrorAs(t, ErrRedirectBackNoFallback, &err)
 }
 
 // go test -run Test_Redirect_Back_WithReferer