Skip to content

Commit 31fec5d

Browse files
committed
fix(logger): remove child from logger type and tighten noop signature
1 parent c798517 commit 31fec5d

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import type { GiselleLogger } from "./types";
22

3-
const noop = () => {};
3+
const noop = (..._args: unknown[]): void => {};
44

55
export const noopLogger: GiselleLogger = {
66
info: noop,
@@ -9,5 +9,4 @@ export const noopLogger: GiselleLogger = {
99
debug: noop,
1010
trace: noop,
1111
fatal: noop,
12-
child: () => noopLogger,
1312
};

packages/giselle/src/logger/types.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
import type { Logger } from "pino";
22

3-
/**
4-
* A logger interface compatible with pino, focusing on core logging methods.
5-
*/
63
export type GiselleLogger = Pick<
74
Logger,
8-
"info" | "warn" | "error" | "debug" | "trace" | "fatal" | "child"
5+
"info" | "warn" | "error" | "debug" | "trace" | "fatal"
96
>;

0 commit comments

Comments
 (0)