Strengthen some Logger tests (#743)

Author: whatyouhide

lib/sentry/logger_handler.ex

@@ -462,6 +462,25 @@ defmodule Sentry.LoggerHandler do
     %{genserver_state: state, last_message: last_message}
   end
 
+  # Sometimes there's an extra sneaky [] in there.
+  defp extra_info_from_message([
+         [
+           "GenServer ",
+           _pid,
+           " terminating",
+           _reason,
+           [],
+           "\nLast message",
+           _from,
+           ": ",
+           last_message
+         ],
+         "\nState: ",
+         state | _rest
+       ]) do
+    %{genserver_state: state, last_message: last_message}
+  end
+
   defp extra_info_from_message(_message) do
     %{}
   end
@@ -471,6 +490,39 @@ defmodule Sentry.LoggerHandler do
   # message, and a treasure trove of stuff. If we cannot parse the message, such is life
   # and we just report it as is.
 
+  defp try_to_parse_message_or_just_report_it(
+         [
+           [
+             "GenServer ",
+             inspected_pid,
+             " terminating",
+             chardata_reason,
+             _whatever_this_is = [],
+             "\nLast message",
+             [" (from ", inspected_sender_pid, ")"],
+             ": ",
+             inspected_last_message
+           ],
+           "\nState: ",
+           inspected_state | _
+         ],
+         sentry_opts,
+         config
+       ) do
+    string_reason = chardata_reason |> :unicode.characters_to_binary() |> String.trim()
+
+    sentry_opts =
+      sentry_opts
+      |> Keyword.put(:interpolation_parameters, [inspected_pid])
+      |> add_extra_to_sentry_opts(%{
+        pid_which_sent_last_message: inspected_sender_pid,
+        last_message: inspected_last_message,
+        genserver_state: inspected_state
+      })
+
+    capture(:message, "GenServer %s terminating: #{string_reason}", sentry_opts, config)
+  end
+
   defp try_to_parse_message_or_just_report_it(
          [
            [

test/sentry/logger_handler_test.exs

@@ -88,14 +88,25 @@ defmodule Sentry.LoggerHandlerTest do
       assert stacktrace_frame.filename == "test/support/example_plug_application.ex"
     end
 
+    test "TODO", %{sender_ref: ref} do
+      start_supervised!(Sentry.ExamplePlugApplication, restart: :temporary)
+      :hackney.get("http://127.0.0.1:8003/error_route", [], "", [])
+      assert_receive {^ref, event}, 1000
+      assert event.original_exception == %RuntimeError{message: "Error"}
+    end
+
     @tag handler_config: %{excluded_domains: []}
     test "sends two errors when a Plug process crashes if cowboy domain is not excluded",
          %{sender_ref: ref} do
       start_supervised!(Sentry.ExamplePlugApplication, restart: :temporary)
 
       :hackney.get("http://127.0.0.1:8003/error_route", [], "", [])
 
-      assert_receive {^ref, _event}, 1000
+      assert_receive {^ref, event}, 1000
+      assert event.original_exception == %RuntimeError{message: "Error"}
+
+      assert_receive {^ref, second_event}, 1000
+      assert second_event.original_exception == %RuntimeError{message: "Error"}
     end
 
     @tag handler_config: %{excluded_domains: []}
@@ -109,6 +120,9 @@ defmodule Sentry.LoggerHandlerTest do
     end
   end
 
+  describe "with Bandit" do
+  end
+
   describe "with capture_log_messages: true" do
     @tag handler_config: %{capture_log_messages: true}
     test "sends error messages by default", %{sender_ref: ref} do