Skip to content

Commit 30a9828

Browse files
committed
Simplify test GenServer
1 parent 4363033 commit 30a9828

File tree

2 files changed

+0
-9
lines changed

2 files changed

+0
-9
lines changed

test/logger_backend_test.exs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ defmodule Sentry.LoggerBackendTest do
5353

5454
{:ok, pid} = Sentry.TestGenServer.start_link(self_pid)
5555
Sentry.TestGenServer.do_throw(pid)
56-
assert_receive "terminating"
5756
assert_receive {^ref, event}
5857
assert event.exception.value == ~s[** (exit) bad return value: "I am throwing"]
5958
end
@@ -65,7 +64,6 @@ defmodule Sentry.LoggerBackendTest do
6564

6665
{:ok, pid} = Sentry.TestGenServer.start_link(self_pid)
6766
Sentry.TestGenServer.bad_exit(pid)
68-
assert_receive "terminating"
6967
assert_receive {^ref, event}
7068
assert event.exception.type == "Sentry.CrashError"
7169
assert event.exception.value == "** (exit) :bad_exit"
@@ -81,7 +79,6 @@ defmodule Sentry.LoggerBackendTest do
8179

8280
Sentry.TestGenServer.add_sentry_breadcrumb(pid, %{message: "test"})
8381
Sentry.TestGenServer.invalid_function(pid)
84-
assert_receive "terminating"
8582
assert_receive {^ref, event}
8683

8784
assert event.exception.type == "FunctionClauseError"
@@ -169,7 +166,6 @@ defmodule Sentry.LoggerBackendTest do
169166
Sentry.TestGenServer.add_logger_metadata(pid, :map, %{a: "b"})
170167
Sentry.TestGenServer.add_logger_metadata(pid, :list, [1, 2, 3])
171168
Sentry.TestGenServer.invalid_function(pid)
172-
assert_receive "terminating"
173169

174170
assert_receive {^ref, event}
175171
assert event.extra.logger_metadata.string == "string"
@@ -189,7 +185,6 @@ defmodule Sentry.LoggerBackendTest do
189185
Sentry.TestGenServer.add_logger_metadata(pid, :number, 43)
190186
Sentry.TestGenServer.add_logger_metadata(pid, :list, [])
191187
Sentry.TestGenServer.invalid_function(pid)
192-
assert_receive "terminating"
193188

194189
assert_receive {^ref, event}
195190
assert event.extra.logger_metadata == %{}

test/support/test_gen_server.exs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,4 @@ defmodule Sentry.TestGenServer do
6161

6262
{:ok, state}
6363
end
64-
65-
def terminate(_, state) do
66-
send(state, "terminating")
67-
end
6864
end

0 commit comments

Comments
 (0)