Package handling

[kriberg]

I was just wondering what the rationale was for installing packages from within the plugin loader? Wouldn't it be better to have the standard python tooling the user is probably already using, rather than using subprocess to call pip3 install?

[fralau]

It's certainly a good question. To address it, could I ask you to be more precise concerning the feature you are referring to, and its location in the source code?

[kriberg]

Here:
https://github.com/fralau/mkdocs-macros-plugin/blob/master/mkdocs_macros/util.py#L170-L177

Called here:
https://github.com/fralau/mkdocs-macros-plugin/blob/master/mkdocs_macros/plugin.py#L572

which is called from on_config()

[fralau]

That's a fair point.

In your view, what steps should the program take at that point?

[kriberg]

I think it's somewhat of a security issue and we should probably remove this. The pluglet loader should try to load modules. If they aren't present, then log an error.

[fralau]

You might be right and it is a corner case anyway; the benefits of automation might not be worth the trouble.

I convert this into an issue.

[fralau]

See #262